move SimpleBlobStore to common package#8972
Closed
buchgr wants to merge 3 commits intobazelbuild:masterfrom
Closed
move SimpleBlobStore to common package#8972buchgr wants to merge 3 commits intobazelbuild:masterfrom
buchgr wants to merge 3 commits intobazelbuild:masterfrom
Conversation
make a drive by change of lib/remote:srcs collecting all the :srcs filegroups of its subpackages
buchgr
force-pushed
the
refactor-blobstore
branch
from
c270fee to
ac28091
Compare
Contributor
Author
|
each commit can be reviewed independently. |
|
I like the refactoring, but there is one unsolved issue. If we are going to make another In short
and
can't be in the same package. It makes sense to leave the first part in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@borkaehw