Skip to content

Fix #2958: Installer should not overwrite bazelrc#2959

Closed
philwo wants to merge 1 commit intomasterfrom
philwo-patch-1
Closed

Fix #2958: Installer should not overwrite bazelrc#2959
philwo wants to merge 1 commit intomasterfrom
philwo-patch-1

Conversation

@philwo
Copy link
Copy Markdown
Member

@philwo philwo commented May 6, 2017

No description provided.

@philwo philwo added category: misc > bootstrap / installation P2 We'll consider working on this in future. (Assignee optional) labels May 6, 2017
@philwo philwo added this to the 0.5 milestone May 6, 2017
@philwo philwo self-assigned this May 6, 2017
@philwo philwo requested a review from damienmg May 6, 2017 07:35
damienmg
damienmg approved these changes May 8, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you believe it should be cherry-picked for #2692? If so add the release bug in the description when importing so the change will ping the bug back.

@philwo
Copy link
Copy Markdown
Member Author

philwo commented May 8, 2017

@damienmg That would be cool :) I'll add the bug to the description then.

@bazel-io bazel-io closed this in 7205611 May 8, 2017
hlopko pushed a commit that referenced this pull request May 10, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
b771c87 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
hlopko pushed a commit that referenced this pull request May 10, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
fcab3b8 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
hlopko pushed a commit that referenced this pull request May 10, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
784d0e0 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
hlopko pushed a commit that referenced this pull request May 11, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
f75b9e3 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
hlopko pushed a commit that referenced this pull request May 17, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
e0f8f56 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
hlopko pushed a commit that referenced this pull request May 17, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
d3315e8 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
@damienmg damienmg deleted the philwo-patch-1 branch May 17, 2017 13:29
hlopko pushed a commit that referenced this pull request May 23, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
44aba5b 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
damienmg pushed a commit that referenced this pull request May 26, 2017
@philwo @damienmg
Fix #2958: Installer should not overwrite bazelrc
3ef1afa 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
hlopko pushed a commit that referenced this pull request May 31, 2017
@philwo @hlopko
Fix #2958: Installer should not overwrite bazelrc
16689bd 
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@damienmg damienmg damienmg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@philwo philwo

Labels

cla: yes P2 We'll consider working on this in future. (Assignee optional)

Projects

None yet

Milestone

0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@philwo @damienmg @googlebot