[8.7.0] Add Socket Secure (SOCKS) proxy support#29305
Merged
iancha1992 merged 7 commits intobazelbuild:release-8.7.0from Apr 16, 2026
Merged
[8.7.0] Add Socket Secure (SOCKS) proxy support#29305iancha1992 merged 7 commits intobazelbuild:release-8.7.0from
iancha1992 merged 7 commits intobazelbuild:release-8.7.0from
Conversation
ssarad
changed the title
ssarad
changed the title
github-actions
Bot
added
team-ExternalDeps
Contributor
Author
|
cc: @meteorcloudy The windows-shard-2 failure seems to be unrelated to the changes as its failing / flaking due to infinite symlink expansion in INFO: Completed output file stat checks, no modified outputs found
Apr 15, 2026 5:18:00 PM com.google.devtools.build.lib.skyframe.SequencedSkyframeExecutor detectModifiedOutputFiles
INFO: Found 1 modified files from last build
ERROR: infinite symlink expansion detected
[start of symlink chain]
C:/b/ahigvc3r/execroot/_main/_tmp/f46842d1774692d5dc4db67c3e4aaa21/_main/foo/dir
C:/b/ahigvc3r/execroot/_main/_tmp/f46842d1774692d5dc4db67c3e4aaa21/_main/foo/dir/subdir/nested2
[end of symlink chain]
Apr 15, 2026 5:18:00 PM com.google.devtools.build.skyframe.AbstractParallelEvaluator$Evaluate run
WARNING: Aborting evaluation while evaluating DirectoryArtifactTraversalRequest{root=DirectTraversalRoot{outputArtifact=null, rootPart=C:/b/ahigvc3r/execroot/_main/_tmp/f46842d1774692d5dc4db67c3e4aaa21/_main, relativePart=foo/dir/subdir/nested2}, isRootGenerated=false, crossPkgBoundaries=CROSS, strictOutputFiles=true, skipTestingForSubpackage=false, errorInfo=Directory artifact foo/dir}
com.google.devtools.build.lib.skyframe.RecursiveFilesystemTraversalFunction$RecursiveFilesystemTraversalFunctionException: com.google.devtools.build.lib.skyframe.RecursiveFilesystemTraversalFunction$RecursiveFilesystemTraversalException: Error while traversing directory foo/dir/subdir/nested2: Infinite symlink expansion
at com.google.devtools.build.lib.skyframe.RecursiveFilesystemTraversalFunction.compute(RecursiveFilesystemTraversalFunction.java:274)
at com.google.devtools.build.lib.skyframe.RecursiveFilesystemTraversalFunction.compute(RecursiveFilesystemTraversalFunction.java:74)
at com.google.devtools.build.skyframe.AbstractParallelEvaluator$Evaluate.run(AbstractParallelEvaluator.java:467)
at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:435)
at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1423)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
Caused by: com.google.devtools.build.lib.skyframe.RecursiveFilesystemTraversalFunction$RecursiveFilesystemTraversalException: Error while traversing directory foo/dir/subdir/nested2: Infinite symlink expansion |
ssarad
changed the title
Merged
via the queue into
bazelbuild:release-8.7.0
with commit Apr 16, 2026
f390018
47 checks passed
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ProxyHelper.javaonly supported HTTP/HTTPS proxies, rejecting SOCKS proxy URLs with the error "Proxy address socks5://... is not a valid URL". This change adds support forsocks://,socks4://, andsocks5://proxy schemes.Changes:
Proxy.Type.SOCKSwhen SOCKS schemes are detectedMotivation
Fixes #29301
Build API Changes
No
Checklist
Release Notes
RELNOTES[NEW]: Added SOCKS proxy support. Bazel now accepts
socks://,socks4://, andsocks5://URLs inHTTPS_PROXY/HTTP_PROXYenvironment variables and related system properties.