[9.1.0] Include both windows and unix files in embedded_zipper_sources#29236
Merged
iancha1992 merged 2 commits intobazelbuild:release-9.1.0from Apr 7, 2026
Merged
Conversation
Guarding against mingw32 is not sufficient when a custom non-mingw32 toolchain injects the type. The added guard allows the toolchain to override this (and only this) typedef. PiperOrigin-RevId: 892509663 Change-Id: I05e7420ccaa73f49c3038e6e67bf32f6661af120
…elbuild#29057) ### Description This filegroup is being built for user's exec platform, which can be different from bazel's platform (= user's host platform). The `select()` selects with bazel's platform, making it impossible to build bazel's internal tools for a different platform. ### Motivation This fixes the "input file not found" error when building with a remote execution platform that is different from the host. ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes bazelbuild#29057. PiperOrigin-RevId: 890318692 Change-Id: Ibfd0ae8d934e2e0ca9726a0ee907b4791c346504
iancha1992
added
team-Rules-CPP
Member
Author
|
For ref, please see #28967 (comment) |
meteorcloudy
approved these changes
Apr 7, 2026
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This filegroup is being built for user's exec platform, which can be different from bazel's platform (= user's host platform). The
select()selects with bazel's platform, making it impossible to build bazel's internal tools for a different platform.Motivation
This fixes the "input file not found" error when building with a remote execution platform that is different from the host.
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Closes #29057.
PiperOrigin-RevId: 890318692
Change-Id: Ibfd0ae8d934e2e0ca9726a0ee907b4791c346504
Commit 919c0d4 and 5cc93ee