Fix launcher/launcher_maker for cross build#29200
Closed
BoleynSu wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix launcher/launcher_maker for cross build#29200BoleynSu wants to merge 1 commit intobazelbuild:masterfrom
BoleynSu wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
|
cc @fmeum |
github-actions
Bot
added
the
awaiting-review
Collaborator
|
Could you explain the situation in which this fixes your build? |
Collaborator
|
Ah, I get it. Thanks for catching this! Looks good to me, but please flesh out the PR description. |
fmeum
approved these changes
Apr 2, 2026
Collaborator
Collaborator
|
@bazel-io fork 9.1.0 |
Collaborator
|
@bazel-io fork 9.0.2 |
Collaborator
|
@bazel-io fork 8.7.0 |
This was referenced Apr 2, 2026
Contributor
Author
|
Description updated |
iancha1992
added
the
team-ExternalDeps
Wyverald
approved these changes
Apr 3, 2026
Wyverald
added
awaiting-PR-merge
github-actions
Bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 7, 2026
### Description Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec. ### Motivation To make py_binary launcher work when building on linux (exec) for windows (target). ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine. Closes bazelbuild#29200. PiperOrigin-RevId: 895761405 Change-Id: I0b3dd3431d25fb4fb9ea827f344eb5cf42c11276
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 7, 2026
### Description Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec. ### Motivation To make py_binary launcher work when building on linux (exec) for windows (target). ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine. Closes bazelbuild#29200. PiperOrigin-RevId: 895761405 Change-Id: I0b3dd3431d25fb4fb9ea827f344eb5cf42c11276
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 7, 2026
### Description Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec. ### Motivation To make py_binary launcher work when building on linux (exec) for windows (target). ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine. Closes bazelbuild#29200. PiperOrigin-RevId: 895761405 Change-Id: I0b3dd3431d25fb4fb9ea827f344eb5cf42c11276
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
### Description Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec. ### Motivation To make py_binary launcher work when building on linux (exec) for windows (target). ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine. Closes #29200. PiperOrigin-RevId: 895761405 Change-Id: I0b3dd3431d25fb4fb9ea827f344eb5cf42c11276 Commit 4ff3127 Co-authored-by: Boleyn Su <[email protected]>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
### Description Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec. ### Motivation To make py_binary launcher work when building on linux (exec) for windows (target). ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine. Closes #29200. PiperOrigin-RevId: 895761405 Change-Id: I0b3dd3431d25fb4fb9ea827f344eb5cf42c11276 Commit 4ff3127 Co-authored-by: Boleyn Su <[email protected]>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
### Description Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec. ### Motivation To make py_binary launcher work when building on linux (exec) for windows (target). ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine. Closes #29200. PiperOrigin-RevId: 895761405 Change-Id: I0b3dd3431d25fb4fb9ea827f344eb5cf42c11276 Commit 4ff3127 Co-authored-by: Boleyn Su <[email protected]>
Member
|
A fix for this issue has been included in Bazel 9.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Contributor
Author
|
I can confirm the issue fixed in 9.1.0rc2. |
sfc-gh-jkuster
pushed a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Apr 23, 2026
### Description Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec. ### Motivation To make py_binary launcher work when building on linux (exec) for windows (target). ### Build API Changes No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine. Closes bazelbuild#29200. PiperOrigin-RevId: 895761405 Change-Id: I0b3dd3431d25fb4fb9ea827f344eb5cf42c11276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix launcher/launcher_maker for cross build. launcher will be used in the build output, so it should use cfg=target. launcher_maker is used to combine a binary for target and launcher for target into the final output at build time, so it should use cfg=exec.
Motivation
To make py_binary launcher work when building on linux (exec) for windows (target).
Build API Changes
No
Checklist
Release Notes
RELNOTES: Fix launcher/launcher_maker for cross build, e.g. build windows binary on linux machine.