remote: allow local fallback for buildRemoteAction failures#29185
Open
coeuvre wants to merge 1 commit intobazelbuild:masterfrom
Open
remote: allow local fallback for buildRemoteAction failures#29185coeuvre wants to merge 1 commit intobazelbuild:masterfrom
coeuvre wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
Bot
added
team-Remote-Exec
If buildRemoteAction fails due to a RemoteExecutionCapabilitiesException, the failure should trigger local fallback if --remote_local_fallback is enabled. Previously, RemoteExecutionCapabilitiesException was caught in buildRemoteAction and re-thrown as an ExecException, which is considered fatal and bypasses the fallback logic in RemoteSpawnRunner and RemoteSpawnCache. Closes bazelbuild#29129
coeuvre
force-pushed
the
push-yymlnnkmkqou
branch
from
ab62a04 to
8877b80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If buildRemoteAction fails due to a RemoteExecutionCapabilitiesException, the failure should trigger local fallback if --remote_local_fallback is enabled.
Previously, RemoteExecutionCapabilitiesException was caught in buildRemoteAction and re-thrown as an ExecException, which is considered fatal and bypasses the fallback logic in RemoteSpawnRunner and RemoteSpawnCache.
Closes #29129