[9.1.0] Ensure that rctx.symlink invalidates correctly if it is a copy (https://github.com/bazelbuild/bazel/pull/28682)#28741
Merged
iancha1992 merged 1 commit intobazelbuild:release-9.1.0from Feb 23, 2026
Conversation
…elbuild#28682) ### Description When `rctx.symlink` is implemented as a copy (on Windows with default settings), the target is now watched so that modifications to it are still seen through the fake "symlink". Motivation ### Build API Changes No ### Checklist - [x] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: `rctx.symlink` now implicitly watches the target if it falls back to a copy. Closes bazelbuild#28682. PiperOrigin-RevId: 873775628 Change-Id: I6bd9d38e19b20e3342802ab4a11acd319b7ac52f
bazel-io
added
team-ExternalDeps
Wyverald
approved these changes
Feb 23, 2026
Merged
via the queue into
bazelbuild:release-9.1.0
with commit Feb 23, 2026
13002c2
46 checks passed
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
rctx.symlinkis implemented as a copy (on Windows with default settings), the target is now watched so that modifications to it are still seen through the fake "symlink".Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES:
rctx.symlinknow implicitly watches the target if it falls back to a copy.Closes #28682.
PiperOrigin-RevId: 873775628
Change-Id: I6bd9d38e19b20e3342802ab4a11acd319b7ac52f
Commit 6dd6396