Fix visibility for implicit deps of parent rules#28627
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix visibility for implicit deps of parent rules#28627fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
fmeum
requested review from
dabanki and
gregestren
and removed request for
a team
github-actions
bot
added
team-Configurability
Collaborator
Author
|
@bazel-io fork 8.6.0 |
Collaborator
Author
|
@bazel-io fork 9.0.1 |
Collaborator
Author
|
@bazel-io fork 9.1.0 |
This was referenced Feb 11, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in visibility checking for implicit dependencies in extended Starlark rules. The change correctly identifies the original rule that introduced an attribute by traversing the inheritance hierarchy. This ensures that the visibility of a default value for an implicit dependency is checked against the package where it was defined, not where it was inherited. The implementation is clean and is accompanied by a thorough test case that validates the fix. The changes look good.
The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule.
fmeum
force-pushed
the
28618-extension-implicit-dep
branch
from
e8b14fc to
3ee9c7e
Compare
brandjon
approved these changes
Feb 11, 2026
Member
brandjon
left a comment
brandjon
left a comment
There was a problem hiding this comment.
I wasn't aware people were actually using rule inheritance. The docstring lists it as experimental, though it's not flag guarded...
In any case, the PR looks ok.
Wyverald
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 17, 2026
The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule. Fixes bazelbuild#28618 Closes bazelbuild#28627. PiperOrigin-RevId: 871303947 Change-Id: I0027e277dc9f01396fa4674297d2a73e1e9d257e
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 17, 2026
The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule. Fixes bazelbuild#28618 Closes bazelbuild#28627. PiperOrigin-RevId: 871303947 Change-Id: I0027e277dc9f01396fa4674297d2a73e1e9d257e
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
…8688) The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule. Fixes #28618 Closes #28627. PiperOrigin-RevId: 871303947 Change-Id: I0027e277dc9f01396fa4674297d2a73e1e9d257e Commit a16489f Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
…8687) The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule. Fixes #28618 Closes #28627. PiperOrigin-RevId: 871303947 Change-Id: I0027e277dc9f01396fa4674297d2a73e1e9d257e Commit a16489f Co-authored-by: Fabian Meumertzheim <[email protected]>
Contributor
|
@brandjon More people know about it because of @keith: https://www.smileykeith.com/2025/10/31/bazel-rule-extensions/ |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Feb 19, 2026
The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule. Fixes bazelbuild#28618 Closes bazelbuild#28627. PiperOrigin-RevId: 871303947 Change-Id: I0027e277dc9f01396fa4674297d2a73e1e9d257e
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2026
…hub.com/… (#28722) …/pull/28627) The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule. Fixes #28618 Closes #28627. PiperOrigin-RevId: 871303947 Change-Id: I0027e277dc9f01396fa4674297d2a73e1e9d257e <!-- Thank you for contributing to Bazel! Please read the contribution guidelines: https://bazel.build/contribute.html --> ### Description <!-- Please provide a brief summary of the changes in this PR. --> ### Motivation <!-- Why is this change important? Does it fix a specific bug or add a new feature? If this PR fixes an existing issue, please link it here (e.g. "Fixes #1234"). --> ### Build API Changes <!-- Does this PR affect the Build API? (e.g. Starlark API, providers, command-line flags, native rules) If yes, please answer the following: 1. Has this been discussed in a design doc or issue? (Please link it) 2. Is the change backward compatible? 3. If it's a breaking change, what is the migration plan? --> No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes <!-- If this is a new feature, please add 'RELNOTES[NEW]: <description>' here. If this is a breaking change, please add 'RELNOTES[INC]: <reason>' here. If this change should be mentioned in release notes, please add 'RELNOTES: <reason>' here. --> RELNOTES: None Commit a16489f --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visibility of a default value of an implicit dep in an extended rule should be checked relative to the definition of the rule that introduced it, which may not be the child rule.
Fixes #28618