[9.0.1] Fix disk cache failures on concurrent read-write access on Windows (h…#28552
Merged
iancha1992 merged 3 commits intobazelbuild:release-9.0.1from Feb 9, 2026
Merged
[9.0.1] Fix disk cache failures on concurrent read-write access on Windows (h…#28552iancha1992 merged 3 commits intobazelbuild:release-9.0.1from
iancha1992 merged 3 commits intobazelbuild:release-9.0.1from
Conversation
…azelbuild#28417) This applies the fix made to the download cache in 753dc97 to the disk cache. Work towards bazelbuild#28408 Closes bazelbuild#28417. PiperOrigin-RevId: 864861790 Change-Id: I6850fc27f3336f44f8d366daac63e4822cb94f73
iancha1992
added
team-ExternalDeps
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a concurrency issue on Windows related to disk cache access by refactoring the fix into a reusable utility within FileSystemUtils. This new utility is then applied to both the DownloadCache and DiskCacheClient, ensuring consistent behavior. The accompanying tests are thorough, including specific unit tests for the new utility and a concurrency test to validate the fix under race conditions. I've identified a minor logical issue in the new concurrency test that could be improved for efficiency and faster feedback on failures.
src/test/java/com/google/devtools/build/lib/remote/disk/DiskCacheClientTest.java
Show resolved
Hide resolved
Member
Author
tjgq
reviewed
Feb 7, 2026
src/test/java/com/google/devtools/build/lib/remote/disk/DiskCacheClientTest.java
Outdated
Show resolved
Hide resolved
…cheClientTest.java Co-authored-by: Tiago Quelhas <[email protected]>
Wyverald
approved these changes
Feb 9, 2026
github-actions
bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ttps://github.com//pull/28417)
This applies the fix made to the download cache in 753dc97 to the disk cache.
Work towards #28408
Closes #28417.
PiperOrigin-RevId: 864861790
Change-Id: I6850fc27f3336f44f8d366daac63e4822cb94f73
Commit 73c8da8