Make overlaid files executable in http_archive#28202
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Make overlaid files executable in http_archive#28202fmeum wants to merge 1 commit intobazelbuild:masterfrom
http_archive#28202fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
bot
added
the
awaiting-review
Collaborator
Author
|
@bazel-io fork 8.6.0 |
fmeum
added
the
soft-release-blocker
Collaborator
Author
|
@bazel-io fork 9.0.0 |
This was referenced Jan 9, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to make overlaid files in http_archive executable to support adding shell scripts. While this is a valid use case, the current implementation makes all overlaid files executable, which is a security concern as it violates the principle of least privilege. My review includes a critical comment suggesting a more secure approach by introducing a new attribute to explicitly specify which files should be executable.
This makes it possible to use registry overlays to add shell scripts.
meteorcloudy
approved these changes
Jan 12, 2026
meteorcloudy
added
awaiting-PR-merge
Wyverald
removed
the
soft-release-blocker
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 13, 2026
This makes it possible to use registry overlays to add shell scripts. Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969 Closes bazelbuild#28202. PiperOrigin-RevId: 855699722 Change-Id: I65891a0cb6d7e99d70ab33c8b38f1c7da943fc09
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 13, 2026
This makes it possible to use registry overlays to add shell scripts. Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969 Closes bazelbuild#28202. PiperOrigin-RevId: 855699722 Change-Id: I65891a0cb6d7e99d70ab33c8b38f1c7da943fc09
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
This makes it possible to use registry overlays to add shell scripts. Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969 Closes #28202. PiperOrigin-RevId: 855699722 Change-Id: I65891a0cb6d7e99d70ab33c8b38f1c7da943fc09 Commit 3efde5a Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
This makes it possible to use registry overlays to add shell scripts. Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969 Closes #28202. PiperOrigin-RevId: 855699722 Change-Id: I65891a0cb6d7e99d70ab33c8b38f1c7da943fc09 Commit 3efde5a Co-authored-by: Fabian Meumertzheim <[email protected]>
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 14, 2026
This makes it possible to use registry overlays to add shell scripts. Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969 Closes bazelbuild#28202. PiperOrigin-RevId: 855699722 Change-Id: I65891a0cb6d7e99d70ab33c8b38f1c7da943fc09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to use registry overlays to add shell scripts.
Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969