Skip to content

[9.0.0] Implement RepoMappingManifestAction#describeKey#28167

Merged
iancha1992 merged 1 commit intobazelbuild:release-9.0.0from
bazel-io:cp28061-9.0.0
Jan 7, 2026
Merged

[9.0.0] Implement RepoMappingManifestAction#describeKey#28167
iancha1992 merged 1 commit intobazelbuild:release-9.0.0from
bazel-io:cp28061-9.0.0

Conversation

@bazel-io
Copy link
Member

@bazel-io bazel-io commented Jan 5, 2026

Work towards #28056

Closes #28061.

PiperOrigin-RevId: 852463750
Change-Id: I100a76adf564aa11dbef1a98f48a6b1389c1d584

Commit 0abde3e

Work towards bazelbuild#28056

Closes bazelbuild#28061.

PiperOrigin-RevId: 852463750
Change-Id: I100a76adf564aa11dbef1a98f48a6b1389c1d584
@bazel-io bazel-io added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Jan 5, 2026
@bazel-io bazel-io requested a review from a team as a code owner January 5, 2026 22:49
@bazel-io bazel-io added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Jan 5, 2026
@bazel-io bazel-io requested a review from Wyverald January 5, 2026 22:49
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements describeKey for RepoMappingManifestAction to improve action cache miss debugging. The implementation correctly mirrors the computeKey method, providing a readable description of the action's key components. The change also includes a beneficial refactoring from MapFn to the more specific CommandLineItem.ExceptionlessMapFn. The changes are correct and improve the codebase.

@iancha1992 iancha1992 enabled auto-merge January 5, 2026 23:27
@iancha1992 iancha1992 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into bazelbuild:release-9.0.0 with commit c46399e Jan 7, 2026
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants