Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 29, 2025

All strings in Bazel are coded as raw bytes with a Latin1 coder. Taking advantage of this in FileDependencyKeySupport#computeCacheKey avoids double encoding and can avoid some buffer copies.

All strings in Bazel are coded as raw bytes with a Latin1 coder. Taking advantage of this in `FileDependencyKeySupport#computeCacheKey` avoids double encoding and can avoid some buffer copies.
@fmeum fmeum marked this pull request as ready for review December 29, 2025 17:00
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 29, 2025
@iancha1992 iancha1992 added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Dec 30, 2025
@meisterT meisterT added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 5, 2026
@copybara-service copybara-service bot closed this in bd877d8 Jan 5, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 5, 2026
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 6, 2026
All strings in Bazel are coded as raw bytes with a Latin1 coder. Taking advantage of this in `FileDependencyKeySupport#computeCacheKey` avoids double encoding and can avoid some buffer copies.

Closes bazelbuild#28117.

PiperOrigin-RevId: 852375819
Change-Id: Ia42d4168a79dc646207ac36a955132280eee2bca
mbland added a commit to mbland/bazel that referenced this pull request Jan 8, 2026
Fixes postsubmit job failures after merging bazelbuild#27463 by aligning the
`.bazelci` postsubmit jobs with `.bazelci/presubmit.yml`. Specifically:

- Disabled Android setup and test targets due to infrastructure changes
  (including but not limited to bazelbuild/continuous-integration#2408).

- Updated the `ubuntu2004` jobs to `ubuntu2004_java11` (not that it
  should matter after the `*_for_testing` repo fix from bazelbuild#27463).

- Updated the `xcode_version` of `macos` jobs.

Contains other touch-ups to synchronize build images, build flags, test
flags, and test targets, as well as to make minor formatting changes.

Produced most changes via: `vimdiff .bazelci/p{re,ost}submit.yml`.
The remaining differences are:

- No sharding in postsubmit jobs.

- Setting `--noremote_accept_cached` in postsubmit jobs

- Including `include_json_profile` blocks in postsubmit jobs.

- The `kythe_ubuntu2004` job sets `index_upload_gcs` to `False` in
  presubmit and `True` in postsubmit.

- The `docs_ubuntu1804` job only exists in presubmit.

Part of bazelbuild#28117.
meteorcloudy pushed a commit that referenced this pull request Jan 9, 2026
Fixes postsubmit job failures after merging #27463 by aligning the
`.bazelci` postsubmit jobs with `.bazelci/presubmit.yml`. Specifically:

- Disabled Android setup and test targets due to infrastructure changes
(including but not limited to bazelbuild/continuous-integration#2408).

- Updated the `ubuntu2004` jobs to `ubuntu2004_java11` (not that it
should matter after the `*_for_testing` repo fix from #27463).

- Updated the `xcode_version` of `macos` jobs.

Contains other touch-ups to synchronize build images, build flags, test
flags, and test targets, as well as to make minor formatting changes.

Produced most changes via: `vimdiff .bazelci/p{re,ost}submit.yml`. The
remaining differences are:

- No sharding in postsubmit jobs.

- Setting `--noremote_accept_cached` in postsubmit jobs

- Including `include_json_profile` blocks in postsubmit jobs.

- The `kythe_ubuntu2004` job sets `index_upload_gcs` to `False` in
presubmit and `True` in postsubmit.

- The `docs_ubuntu1804` job only exists in presubmit.

Part of #28117.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants