[8.6.0] Enable --experimental_retain_test_configuration_across_testonly#28115
Merged
iancha1992 merged 1 commit intobazelbuild:release-8.6.0from Jan 5, 2026
Merged
[8.6.0] Enable --experimental_retain_test_configuration_across_testonly#28115iancha1992 merged 1 commit intobazelbuild:release-8.6.0from
--experimental_retain_test_configuration_across_testonly#28115iancha1992 merged 1 commit intobazelbuild:release-8.6.0from
Conversation
This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes bazelbuild#28056 Closes bazelbuild#28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
bazel-io
added
the
team-Configurability
bazel-io
added
team-ExternalDeps
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes the default value of the experimental_retain_test_configuration_across_testonly flag to true. This is intended to mitigate action conflicts when testonly non-test targets depend on test targets. The change is straightforward and seems appropriate for an experimental flag that is moving towards being enabled by default. The provided tests appear to cover the behavior with the new default.
gregestren
added
awaiting-PR-merge
iancha1992
removed
the
awaiting-PR-merge
Member
|
@gregestren Could you please approve? |
gregestren
approved these changes
Jan 5, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Feb 27, 2026
### What does this PR do? Bump `.bazelversion` from 8.5.1 to 8.6.0. ### Motivation Selected changes between 8.5.1 and 8.6.0: - Fix visibility for implicit deps of parent rules (bazelbuild/bazel#28722) - Force rctx.{download_and,}extract to create user-readable files (bazelbuild/bazel#28551) - Fix disk cache failures on concurrent read-write access on Windows (bazelbuild/bazel#28529) - Add a target_type argument to ctx.actions.symlink (bazelbuild/bazel#28538) - Compensate for Windows filesystems lacking junction support (bazelbuild/bazel#28367) (our fix) - Add short_uncached and detailed_uncached options to --test_summary (bazelbuild/bazel#28343) - Add --experimental_strict_repo_env option (bazelbuild/bazel#28189) - Make overlaid files executable in http_archive (bazelbuild/bazel#28277) - Add bazel mod show_repo --all_repos and --all_visible_repos (bazelbuild/bazel#28012) - Enable --experimental_retain_test_configuration_across_testonly (bazelbuild/bazel#28115) - Add option to continue with local execution if remote cache is unavailable (bazelbuild/bazel#28001)
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Feb 27, 2026
### What does this PR do? Bump `.bazelversion` from 8.5.1 to 8.6.0. ### Motivation Selected changes between 8.5.1 and 8.6.0: - Fix visibility for implicit deps of parent rules (bazelbuild/bazel#28722) - Force rctx.{download_and,}extract to create user-readable files (bazelbuild/bazel#28551) - Fix disk cache failures on concurrent read-write access on Windows (bazelbuild/bazel#28529) - Add a target_type argument to ctx.actions.symlink (bazelbuild/bazel#28538) - Compensate for Windows filesystems lacking junction support (bazelbuild/bazel#28367) (our fix) - Add short_uncached and detailed_uncached options to --test_summary (bazelbuild/bazel#28343) - Add --experimental_strict_repo_env option (bazelbuild/bazel#28189) - Make overlaid files executable in http_archive (bazelbuild/bazel#28277) - Add bazel mod show_repo --all_repos and --all_visible_repos (bazelbuild/bazel#28012) - Enable --experimental_retain_test_configuration_across_testonly (bazelbuild/bazel#28115) - Add option to continue with local execution if remote cache is unavailable (bazelbuild/bazel#28001)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids action conflicts when
testonlynon-test targets depend on test targets.Until
--incompatible_check_testonly_for_output_filesis flipped, it is still possible to get action conflicts when a non-testonlytarget depends on an output file of a test. Since this can be fixed by adding the missingtestonlyannotation, this is only a minor concern.Fixes #28056
Closes #28073.
PiperOrigin-RevId: 847892897
Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
Commit bcd8bcb