Skip to content

Delete BazelPythonConfiguration#27842

Closed
gregestren wants to merge 11 commits intobazelbuild:masterfrom
gregestren:no_native_python_flags
Closed

Delete BazelPythonConfiguration#27842
gregestren wants to merge 11 commits intobazelbuild:masterfrom
gregestren:no_native_python_flags

Conversation

@gregestren
Copy link
Contributor

@gregestren gregestren commented Dec 3, 2025

This removes hard-coded flags --python_path, --experimental_python_import_all_repositories, and --incompatible_remove_ctx_bazel_py_fragment.

The first two are redefined in rules_python 1.7.0+ and linked into Bazel in #27792. This PR graveyards them but we can delete them outright when #27793 merges.

--incompatible_remove_ctx_bazel_py_fragment was added in Bazel 9 to allow toggling between the native and Starlark definitions.

By removing --incompatible_remove_ctx_bazel_py_fragment, this change removes the ability to revert to native definitions for post-9 Bazel.

For #26521 and bazel-contrib/rules_python#3252.

@gregestren gregestren changed the title DRAFT: test removing native Python flags. DRAFT: Delete BazelPythonConfiguration Dec 3, 2025
@gregestren gregestren marked this pull request as ready for review December 3, 2025 23:21
@gregestren gregestren requested a review from rickeylev as a code owner December 3, 2025 23:21
@gregestren gregestren requested a review from dabanki December 3, 2025 23:22
@github-actions github-actions bot added team-Rules-Python Native rules for Python awaiting-review PR is awaiting review from an assigned reviewer labels Dec 3, 2025
@gregestren gregestren added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Dec 3, 2025
@gregestren gregestren changed the title DRAFT: Delete BazelPythonConfiguration Delete BazelPythonConfiguration Dec 3, 2025
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 8, 2025
@copybara-service copybara-service bot closed this in 6df13df Dec 9, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 9, 2025
copybara-service bot pushed a commit that referenced this pull request Dec 12, 2025
Related to #27842.

This removes hard-coded flags `--build_python_zip`, `--incompatible_default_to_explicit_init_py`, `--python_native_rules_allowlist`, `incompatible_python_disallow_native_rules`, and `incompatible_remove_ctx_py_fragment`.

These flags are re-difined in rules_python 1.7.0+ and linked into Bazel in #27792. This PR graveyards them but we can delete them outright when #27793 merges.

By removing --incompatible_remove_ctx_py_fragment, this change removes the ability to revert to native definitions for post-9 Bazel.

For #26521 and bazel-contrib/rules_python#3252.

Closes #27900.

PiperOrigin-RevId: 843734148
Change-Id: I1bb9624b3e5a579f6aa50663eb63ef4d7d482b57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-Python Native rules for Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants