Upgrade rules_python to 1.7.0 by dabanki · Pull Request #27792 · bazelbuild/bazel

dabanki · 2025-11-25T16:01:40Z

This is a fork of #27498.

From the comments/open items on that PR, I've:

Removed the tests that were called out as not needed.
Added manual tag to focus_test to avoid pickup in larger runs until issue with --experimental_enable_skyfocus is resolved.
Switched failing test cases from using from bazel_tools.tools.python.runfiles import runfiles to use from python.runfiles import runfiles

There are still a couple failing tests, looking for some guidance on if these can be removed/ignored:

test_source_file_does_not_override_standard_library FAILED: Expected regexp 'I am lib!' not found.

and

1) explicitInitPy_CanBeSelectivelyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest)
value of      : getEmptyFilenames()
unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py
---
expected      : [pkg/__init__.py]
but was       : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py]
	at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeSelectivelyDisabled(BazelPyBinaryConfiguredTargetTest.java:235)
2) explicitInitPy_CanBeGloballyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest)
value of      : getEmptyFilenames()
unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py
---
expected      : [pkg/__init__.py]
but was       : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py]
	at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeGloballyDisabled(BazelPyBinaryConfiguredTargetTest.java:250)

dabanki · 2025-11-25T16:15:04Z

@rickeylev Do the test modifications look okay to you? And do the failing test look important or can they also be removed?

cc @meteorcloudy

rickeylev · 2025-11-25T18:20:26Z

lgtm

dabanki · 2025-11-25T21:09:45Z

Thanks for taking a look! Do the failing tests look like legitimate issues to you?

meteorcloudy · 2025-11-26T09:56:58Z

@bazel-io fork 9.0.0

Removing some more obsolete tests that fail with the new version update.

gregestren · 2025-12-02T21:27:39Z

src/test/py/bazel/bzlmod/bazel_vendor_test.py

    self.ScratchFile('BUILD')

    # Vendor, assert and build with no problems
+    self.RunBazel(['vendor', '--vendor_dir=vendor', '@@rules_python+//python/config_settings:python_path'])


Maybe add a comment that (I think) we only need this until

bazel/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java

Lines 3239 to 3258 in 57ccfd7

private static final ImmutableMap<String, String> PY_FLAG_ALIASES =

ImmutableMap.of(

// LINT.IfChange

"build_python_zip",

"@@rules_python+//python/config_settings:build_python_zip",

"incompatible_default_to_explicit_init_py",

"@@rules_python+//python/config_settings:incompatible_default_to_explicit_init_py");

// LINT.ThenChange(//src/main/java/com/google/devtools/build/lib/rules/python/PythonConfiguration.java)

/** Canonical Starlark flag aliases for {@link BazelPythonConfiguration} flags. */

// TODO: b/453809359 - Remove when Bazel 9+ can read Python flag alias definitions straight from

// rules_python's MODULE.bazel.

private static final ImmutableMap<String, String> BAZEL_PY_FLAG_ALIASES =

ImmutableMap.of(

// LINT.IfChange

"python_path",

"@@rules_python+//python/config_settings:python_path",

"experimental_python_import_all_repositories",

"@@rules_python+//python/config_settings:experimental_python_import_all_repositories");

is removed?

This is a fork of bazelbuild#27498. From the comments/open items on that PR, I've: 1. Removed the tests that were called out as not needed. 2. Added manual tag to `focus_test` to avoid pickup in larger runs until issue with `--experimental_enable_skyfocus` is resolved. 3. Switched failing test cases from using `from bazel_tools.tools.python.runfiles import runfiles` to use `from python.runfiles import runfiles` There are still a couple failing tests, looking for some guidance on if these can be removed/ignored: ``` test_source_file_does_not_override_standard_library FAILED: Expected regexp 'I am lib!' not found. ``` and ``` 1) explicitInitPy_CanBeSelectivelyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest) value of : getEmptyFilenames() unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py --- expected : [pkg/__init__.py] but was : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py] at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeSelectivelyDisabled(BazelPyBinaryConfiguredTargetTest.java:235) 2) explicitInitPy_CanBeGloballyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest) value of : getEmptyFilenames() unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py --- expected : [pkg/__init__.py] but was : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py] at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeGloballyDisabled(BazelPyBinaryConfiguredTargetTest.java:250) ``` Closes bazelbuild#27792. PiperOrigin-RevId: 839448559 Change-Id: I888614dd92fcbc4deda63a86a452bbd94e8f1523

This is a fork of #27498. From the comments/open items on that PR, I've: 1. Removed the tests that were called out as not needed. 2. Added manual tag to `focus_test` to avoid pickup in larger runs until issue with `--experimental_enable_skyfocus` is resolved. 3. Switched failing test cases from using `from bazel_tools.tools.python.runfiles import runfiles` to use `from python.runfiles import runfiles` There are still a couple failing tests, looking for some guidance on if these can be removed/ignored: ``` test_source_file_does_not_override_standard_library FAILED: Expected regexp 'I am lib!' not found. ``` and ``` 1) explicitInitPy_CanBeSelectivelyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest) value of : getEmptyFilenames() unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py --- expected : [pkg/__init__.py] but was : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py] at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeSelectivelyDisabled(BazelPyBinaryConfiguredTargetTest.java:235) 2) explicitInitPy_CanBeGloballyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest) value of : getEmptyFilenames() unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py --- expected : [pkg/__init__.py] but was : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py] at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeGloballyDisabled(BazelPyBinaryConfiguredTargetTest.java:250) ``` Closes #27792. PiperOrigin-RevId: 839448559 Change-Id: I888614dd92fcbc4deda63a86a452bbd94e8f1523 Commit fbe3009 --------- Co-authored-by: Damian Banki <[email protected]>

This removes hard-coded flags `--python_path`, `--experimental_python_import_all_repositories`, and `--incompatible_remove_ctx_bazel_py_fragment`. The first two are redefined in `rules_python` 1.7.0+ and linked into Bazel in #27792. This PR graveyards them but we can delete them outright when #27793 merges. `--incompatible_remove_ctx_bazel_py_fragment` was added in Bazel 9 to allow toggling between the native and Starlark definitions. By removing `--incompatible_remove_ctx_bazel_py_fragment`, this change removes the ability to revert to native definitions for post-9 Bazel. For #26521 and bazel-contrib/rules_python#3252. Closes #27842. PiperOrigin-RevId: 842305784 Change-Id: If55aa925d0cd546e0671ddcb44f9e2819697b22f

Related to #27842. This removes hard-coded flags `--build_python_zip`, `--incompatible_default_to_explicit_init_py`, `--python_native_rules_allowlist`, `incompatible_python_disallow_native_rules`, and `incompatible_remove_ctx_py_fragment`. These flags are re-difined in rules_python 1.7.0+ and linked into Bazel in #27792. This PR graveyards them but we can delete them outright when #27793 merges. By removing --incompatible_remove_ctx_py_fragment, this change removes the ability to revert to native definitions for post-9 Bazel. For #26521 and bazel-contrib/rules_python#3252. Closes #27900. PiperOrigin-RevId: 843734148 Change-Id: I1bb9624b3e5a579f6aa50663eb63ef4d7d482b57

github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 25, 2025

bazel-io mentioned this pull request Nov 26, 2025

[9.0.0] Upgrade rules_python to 1.7.0 #27798

Closed

dabanki requested review from Wyverald and meteorcloudy as code owners December 1, 2025 22:01

dabanki force-pushed the pr/27498 branch from 7518c77 to cea79e1 Compare December 1, 2025 23:03

iancha1992 added team-Rules-Python Native rules for Python team-Configurability platforms, toolchains, cquery, select(), config transitions labels Dec 2, 2025

meteorcloudy and others added 8 commits December 2, 2025 11:35

Upgrade rules_python to 1.7.0-rc4

c9d718f

Fix

87ecb1a

Add missing flags

a41189c

Fix runfiles test

1f3dbfc

Fix //src/test/shell/integration:configured_query_test

b94ce81

Fix blocking tests for rules python python update

0f3bd8e

Remove obsolete python tests

962fddc

Removing some more obsolete tests that fail with the new version update.

Remove EnsurePythonPathOption for Windows

50965c3

dabanki force-pushed the pr/27498 branch 2 times, most recently from cad6ea7 to ea945c0 Compare December 2, 2025 17:11

Resolving dependency version errors from rebase

a990c93

dabanki force-pushed the pr/27498 branch from ea945c0 to a990c93 Compare December 2, 2025 17:31

dabanki added 2 commits December 2, 2025 14:25

Adding back EnsurePythonPathOption for windows

9d31894

Adding rules_python repo in nofetch test due to Windows dependency

b5ce5c9

dabanki force-pushed the pr/27498 branch from d1a1730 to b5ce5c9 Compare December 2, 2025 19:27

Changing flag alias test to account for transitive aliases

3c1ea35

dabanki force-pushed the pr/27498 branch from 7ccc887 to 3c1ea35 Compare December 2, 2025 20:27

dabanki added 2 commits December 2, 2025 15:43

Switch vendor dependency to complete label

f79c1bd

Lint issue

822bebf

gregestren approved these changes Dec 2, 2025

View reviewed changes

copybara-service bot closed this in fbe3009 Dec 2, 2025

github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 2, 2025

bazel-io mentioned this pull request Dec 2, 2025

[9.0.0] Upgrade rules_python to 1.7.0 #27841

Merged

gregestren mentioned this pull request Dec 3, 2025

Delete BazelPythonConfiguration #27842

Closed

meteorcloudy mentioned this pull request Dec 3, 2025

Remove --python_path flag #7901

Open

dabanki mentioned this pull request Dec 8, 2025

Deleting PythonOptions and PythonConfiguration #27900

Closed

dabanki deleted the pr/27498 branch December 18, 2025 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade rules_python to 1.7.0#27792

Upgrade rules_python to 1.7.0#27792
dabanki wants to merge 14 commits intobazelbuild:masterfrom
dabanki:pr/27498

dabanki commented Nov 25, 2025

Uh oh!

dabanki commented Nov 25, 2025

Uh oh!

rickeylev commented Nov 25, 2025

Uh oh!

dabanki commented Nov 25, 2025

Uh oh!

meteorcloudy commented Nov 26, 2025

Uh oh!

gregestren Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	private static final ImmutableMap<String, String> PY_FLAG_ALIASES =
	ImmutableMap.of(
	// LINT.IfChange
	"build_python_zip",
	"@@rules_python+//python/config_settings:build_python_zip",
	"incompatible_default_to_explicit_init_py",
	"@@rules_python+//python/config_settings:incompatible_default_to_explicit_init_py");

	// LINT.ThenChange(//src/main/java/com/google/devtools/build/lib/rules/python/PythonConfiguration.java)

	/** Canonical Starlark flag aliases for {@link BazelPythonConfiguration} flags. */
	// TODO: b/453809359 - Remove when Bazel 9+ can read Python flag alias definitions straight from
	// rules_python's MODULE.bazel.
	private static final ImmutableMap<String, String> BAZEL_PY_FLAG_ALIASES =
	ImmutableMap.of(
	// LINT.IfChange
	"python_path",
	"@@rules_python+//python/config_settings:python_path",
	"experimental_python_import_all_repositories",
	"@@rules_python+//python/config_settings:experimental_python_import_all_repositories");

Conversation

dabanki commented Nov 25, 2025

Uh oh!

dabanki commented Nov 25, 2025

Uh oh!

rickeylev commented Nov 25, 2025

Uh oh!

dabanki commented Nov 25, 2025

Uh oh!

meteorcloudy commented Nov 26, 2025

Uh oh!

gregestren Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants