fix dynamic library .pyd support#27434
Closed
Mizux wants to merge 4 commits into
Closed
Conversation
Mizux
commented
Oct 28, 2025
Mizux
commented
Contributor
- should fix List of allowed shared library file types should come from toolchain #17117
- related to Try fixing dynamic library .pyd support for windows rules_cc#501
- needed to fix pybind_extension do not behave the same on windows (not working as a deps) pybind/pybind11_bazel#124
github-actions
Bot
added
team-Rules-CPP
* should fix bazelbuild#17117 * related to bazelbuild/rules_cc#501 * needed to fix pybind/pybind11_bazel#124
pzembrod
approved these changes
Oct 29, 2025
pzembrod
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.