Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 23, 2025

This drops a few extension entries that would otherwise be contained in the lockfile of every Bazel project, even an empty one.

@fmeum fmeum force-pushed the project-no-extensions branch from 6236dd8 to d33da35 Compare September 24, 2025 08:23
@fmeum fmeum requested a review from meteorcloudy September 24, 2025 08:23
@fmeum fmeum marked this pull request as ready for review September 24, 2025 08:23
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 24, 2025
@fmeum fmeum force-pushed the project-no-extensions branch from d33da35 to b0ff0e9 Compare September 24, 2025 08:33
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmeum fmeum force-pushed the project-no-extensions branch 2 times, most recently from 76c0a9d to 0c4ddeb Compare September 24, 2025 10:37
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 24, 2025

@keith CI fails with this error (sic on the @) after an update of rules_apple:

(12:41:30) ERROR: /private/var/tmp/_bazel_buildkite/8de60991604dec4c6729f5e7e5fbd30c/external/abseil-cpp+/absl/time/internal/cctz/BUILD.bazel:40:11: Compiling absl/time/internal/cctz/src/time_zone_info.cc failed: undeclared inclusion(s) in rule '@@abseil-cpp+//absl/time/internal/cctz:time_zone':
--
  | this rule is missing dependency declarations for the following files included by 'absl/time/internal/cctz/src/time_zone_info.cc':
  | '�A@plications/Xcode16.4.app/Cont@nds/Developer/Platforms/MacOSX. latform/Developer/SDKs/MacOSX15�5.sdk/usr/include/c++/v1/__type_traits/remove_volatile.h'

Any idea how that might happen?

@keith
Copy link
Member

keith commented Sep 24, 2025

based on the bogus-ness in that error im inclined to think it's not on the rules?

@keith
Copy link
Member

keith commented Sep 24, 2025

but i guess given this diff 🤔

@keith
Copy link
Member

keith commented Sep 24, 2025

can you test the update with just apple_support? since i don't think abseil is affected by rules_apple, the diff looks pretty harmless to me bazelbuild/apple_support@1.22.1...1.23.1

@fmeum fmeum force-pushed the project-no-extensions branch 2 times, most recently from c8ea5e2 to 1f1e287 Compare September 24, 2025 16:14
@fmeum fmeum force-pushed the project-no-extensions branch from 09d7eae to 5ac4e0c Compare September 27, 2025 06:54
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 27, 2025

@keith Just apple_support works fine

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 29, 2025
@iancha1992
Copy link
Member

@bazel-io fork 8.4.2

@iancha1992
Copy link
Member

@bazel-io fork 8.5.0

@iancha1992
Copy link
Member

@bazel-io fork 7.7.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 29, 2025
meteorcloudy pushed a commit to meteorcloudy/bazel that referenced this pull request Sep 29, 2025
This drops a few extension entries that would otherwise be contained in the lockfile of every Bazel project, even an empty one.

Closes bazelbuild#27065.

PiperOrigin-RevId: 812741057
Change-Id: Ibe879ebf9af0091c31c8e16ef1e2680acb9de004
meteorcloudy pushed a commit to meteorcloudy/bazel that referenced this pull request Sep 29, 2025
This drops a few extension entries that would otherwise be contained in the lockfile of every Bazel project, even an empty one.

Closes bazelbuild#27065.

PiperOrigin-RevId: 812741057
Change-Id: Ibe879ebf9af0091c31c8e16ef1e2680acb9de004
meteorcloudy added a commit that referenced this pull request Sep 29, 2025
This drops a few extension entries that would otherwise be contained in
the lockfile of every Bazel project, even an empty one.

Closes #27065.

PiperOrigin-RevId: 812741057
Change-Id: Ibe879ebf9af0091c31c8e16ef1e2680acb9de004

Co-authored-by: Fabian Meumertzheim <[email protected]>
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 29, 2025
This drops a few extension entries that would otherwise be contained in
the lockfile of every Bazel project, even an empty one.

Closes bazelbuild#27065.

PiperOrigin-RevId: 812741057
Change-Id: Ibe879ebf9af0091c31c8e16ef1e2680acb9de004

---------

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants