Use feature instead of cpp fragment for dSYM generation#26925
Closed
Use feature instead of cpp fragment for dSYM generation#26925
Conversation
This was discussed in #25881 where we believed it was equivalent. This isn't equivalent if the toolchain does not support dSYM generations but --apple_generate_dsym is still passed (as is possible on Linux). In this case we let feature configuration handle this instead, as this feature is requested when --apple_generate_dsym is passed. In that case because of this mismatch this directory will be created "successfully" but it will always be empty (this would be a failure if it wasn't a tree artifact)
github-actions
bot
added
the
awaiting-review
Member
Author
|
cc @benjivos @googlewalt since this was discussed here #25881 (comment) |
Member
Author
|
my specific use case is a build where i can cross compile some things to macOS from linux, in that case I always want to pass --apple_generate_dsym, but the target may or may not be macOS, so it's easier to differentiate from the toolchain feature which isn't supported for binaries targeting linux |
Member
Author
|
@googlewalt friendly ping 🙏🏻 |
googlewalt
approved these changes
Oct 21, 2025
Member
Author
|
@googlewalt can you help land this one? |
Contributor
|
@comius is there anyone on the bazel side who can help land this? |
Member
Author
|
Ah hopefully @pzembrod can help |
Member
Author
|
@pzembrod ptal |
github-actions
bot
removed
the
awaiting-review
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Jan 6, 2026
This was discussed in bazelbuild#25881 where we believed it was equivalent. This isn't equivalent if the toolchain does not support dSYM generations but --apple_generate_dsym is still passed (as is possible on Linux). In this case we let feature configuration handle this instead, as this feature is requested when --apple_generate_dsym is passed. In that case because of this mismatch this directory will be created "successfully" but it will always be empty (this would be a failure if it wasn't a tree artifact) Closes bazelbuild#26925. PiperOrigin-RevId: 848240203 Change-Id: I604bc97e44c195142b12222b73d7442a1115ccd1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed in #25881
where we believed it was equivalent. This isn't equivalent if the
toolchain does not support dSYM generations but --apple_generate_dsym is
still passed (as is possible on Linux). In this case we let feature
configuration handle this instead, as this feature is requested when
--apple_generate_dsym is passed. In that case because of this mismatch
this directory will be created "successfully" but it will always be
empty (this would be a failure if it wasn't a tree artifact)