[8.4.0] Overlay the registry MODULE.bazel file on the module repo
#26462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes bazelbuild#26217 Closes bazelbuild#26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9
iancha1992
added
team-ExternalDeps
Member
|
@fmeum PTAL |
Collaborator
|
@iancha1992 This patch should fix the test: diff --git a/src/test/py/bazel/bzlmod/mod_command_test.py b/src/test/py/bazel/bzlmod/mod_command_test.py
index f032bbc1ae..5915e6724e 100644
--- a/src/test/py/bazel/bzlmod/mod_command_test.py
+++ b/src/test/py/bazel/bzlmod/mod_command_test.py
@@ -476,9 +476,9 @@ class ModCommandTest(test_base.TestBase):
stdout.pop(44)
self.assertRegex(stdout.pop(49), r'^ urls = \[".*"\],$')
self.assertRegex(stdout.pop(49), r'^ integrity = ".*",$')
- self.assertRegex(stdout.pop(53), r'^ remote_module_file_urls = \[".*"\],$')
+ self.assertRegex(stdout.pop(52), r'^ remote_module_file_urls = \[".*"\],$')
self.assertRegex(
- stdout.pop(53), r'^ remote_module_file_integrity = ".*",$'
+ stdout.pop(52), r'^ remote_module_file_integrity = ".*",$'
)
# lines after '# Rule http_archive defined at (most recent call last):'
stdout.pop(13)
@@ -545,8 +545,8 @@ class ModCommandTest(test_base.TestBase):
' strip_prefix = "",',
' remote_file_urls = {},',
' remote_file_integrity = {},',
- # pop(53) -- remote_module_file_urls=[...]
- # pop(53) -- remote_module_file_integrity=...
+ # pop(52) -- remote_module_file_urls=[...]
+ # pop(52) -- remote_module_file_integrity=...
' remote_patches = {},',
' remote_patch_strip = 0,',
')', |
Member
Author
@fmeum Done! Thank you |
Contributor
|
How annoying would a 7 backport for this be? |
Collaborator
The backport itself should be fine. @meteorcloudy What do you think of one more 7.x release closer to the Bazel 9 release? |
Member
SG, if this is actually doable, we can mark it as potential cherry pick for 7 |
Collaborator
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
meteorcloudy
approved these changes
Jul 8, 2025
github-actions
bot
removed
the
awaiting-review
iancha1992
added
potential 7.x cherry-picks
iancha1992
removed
the
potential 7.x cherry-picks
dd-mergequeue bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 25, 2025
### Motivation See: - https://github.com/bazelbuild/bazel/releases/tag/8.4.0 - https://github.com/bazelbuild/bazel/releases/tag/8.4.1 - https://github.com/bazelbuild/bazel/releases/tag/8.4.2 (8.5.0 is due soon) #### Cache & reliability - 8.4.0 honors XDG_CACHE_HOME on macOS, which will definitely help ([ABLD-300](https://datadoghq.atlassian.net/browse/ABLD-300)): bazelbuild/bazel#26773 - 8.4.1 fixes a race condition affecting repository contents cache: bazelbuild/bazel#26950 - 8.4.0 fixes another race condition affecting workers: bazelbuild/bazel#26475 #### Modules - 8.4.0 brings new `--module_mirrors` flag for fallback URLs when primary sources are slow/unavailable: bazelbuild/bazel#26850 - 8.4.0 avoids the need for dummy `MODULE.bazel` files with `git_repository`/`http_archive`: bazelbuild/bazel#26462 - 8.4.2 fixes a maintenance annoyance for `MODULE.bazel.lock` file: bazelbuild/bazel#27111 #### Platforms - 8.4.0 allows to mitigate the long path issue with **MSVC on Windows**: bazelbuild/bazel#26532 - 8.4.2 fixes **macOS** compatibility issues: bazelbuild/bazel#27014 [ABLD-300]: https://datadoghq.atlassian.net/browse/ABLD-300?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: regis.desgroppes <[email protected]>
chouquette
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 27, 2025
### Motivation See: - https://github.com/bazelbuild/bazel/releases/tag/8.4.0 - https://github.com/bazelbuild/bazel/releases/tag/8.4.1 - https://github.com/bazelbuild/bazel/releases/tag/8.4.2 (8.5.0 is due soon) #### Cache & reliability - 8.4.0 honors XDG_CACHE_HOME on macOS, which will definitely help ([ABLD-300](https://datadoghq.atlassian.net/browse/ABLD-300)): bazelbuild/bazel#26773 - 8.4.1 fixes a race condition affecting repository contents cache: bazelbuild/bazel#26950 - 8.4.0 fixes another race condition affecting workers: bazelbuild/bazel#26475 #### Modules - 8.4.0 brings new `--module_mirrors` flag for fallback URLs when primary sources are slow/unavailable: bazelbuild/bazel#26850 - 8.4.0 avoids the need for dummy `MODULE.bazel` files with `git_repository`/`http_archive`: bazelbuild/bazel#26462 - 8.4.2 fixes a maintenance annoyance for `MODULE.bazel.lock` file: bazelbuild/bazel#27111 #### Platforms - 8.4.0 allows to mitigate the long path issue with **MSVC on Windows**: bazelbuild/bazel#26532 - 8.4.2 fixes **macOS** compatibility issues: bazelbuild/bazel#27014 [ABLD-300]: https://datadoghq.atlassian.net/browse/ABLD-300?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: regis.desgroppes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELNOTES: Modules backed by
http_archiveorgit_repositoryno longer require a MODULE.bazel file to be contained in the source archive.Fixes #26217
Closes #26332.
PiperOrigin-RevId: 778139801
Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9
Commit c5a562b