Add --incompatible_filegroup_runfiles_for_data#25978
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Add --incompatible_filegroup_runfiles_for_data#25978fmeum wants to merge 1 commit intobazelbuild:masterfrom
--incompatible_filegroup_runfiles_for_data#25978fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
fmeum
force-pushed
the
incompatible-filegroup-runfiles
branch
from
f761cd4 to
ed874ee
Compare
fmeum
requested review from
gregestren and
meteorcloudy
and removed request for
a team and
gregestren
github-actions
bot
added
team-Configurability
meteorcloudy
approved these changes
Apr 30, 2025
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
LGTM.
Waiting for @lberki to take a look. Maybe we could flip this flag in Bazel but keep it disabled in google3?
Collaborator
Author
Yes, I think that's going to be the fate of the flag, similar to the one that governs canonical label stringification. |
Collaborator
Author
|
@lberki Friendly ping |
Collaborator
Author
|
@meteorcloudy @lberki Friendly ping :-) |
Contributor
|
Uh, sorry, this took an embarrassingly long time. I'm not too hot about adding another knob, but it's an improvement over abusing |
lberki
approved these changes
Jun 17, 2025
Member
|
@fmeum Can you please resolve the conflict so that we can import it? |
# Conflicts: # src/main/java/com/google/devtools/build/lib/rules/filegroup/Filegroup.java
fmeum
force-pushed
the
incompatible-filegroup-runfiles
branch
from
ed874ee to
3b2053c
Compare
Collaborator
Author
|
@meteorcloudy Done! |
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 8.4.0 |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 5, 2025
If true, runfiles of targets listed in the srcs attribute of a filegroup are available to targets that consume the filegroup as a data dependency. Reland of bazelbuild#25365 behind an incompatible flag Closes bazelbuild#25978. PiperOrigin-RevId: 772841978 Change-Id: Ia8f126bb33e02969eafdbd6972c83f5350d58be2 (cherry picked from commit cac453b)
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 5, 2025
If true, runfiles of targets listed in the srcs attribute of a filegroup are available to targets that consume the filegroup as a data dependency. Reland of bazelbuild#25365 behind an incompatible flag Closes bazelbuild#25978. PiperOrigin-RevId: 772841978 Change-Id: Ia8f126bb33e02969eafdbd6972c83f5350d58be2 (cherry picked from commit cac453b)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
If true, runfiles of targets listed in the srcs attribute of a filegroup are available to targets that consume the filegroup as a data dependency. Reland of #25365 behind an incompatible flag Closes #25978. PiperOrigin-RevId: 772841978 Change-Id: Ia8f126bb33e02969eafdbd6972c83f5350d58be2 (cherry picked from commit cac453b) Closes #26419
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If true, runfiles of targets listed in the srcs attribute of a filegroup are available to targets that consume the filegroup as a data dependency.
Reland of #25365 behind an incompatible flag