Make WorkerInstance a @ClassRule @Rule#25432
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Conversation
github-actions
Bot
added
team-Remote-Exec
fmeum
force-pushed
the
refactor-worker-instance
branch
from
b72fd36 to
81862f6
Compare
Collaborator
Author
|
@bazel-io fork 8.2.0 |
This makes it easier to use in tests and also avoids restarting the worker for each test by only deleting its state.
fmeum
force-pushed
the
refactor-worker-instance
branch
from
81862f6 to
a26e8e6
Compare
fmeum
commented
Mar 3, 2025
coeuvre
approved these changes
Mar 4, 2025
coeuvre
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 8.2.0 |
github-actions
Bot
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Mar 7, 2025
This makes it easier to use in tests and also avoids restarting the worker for each test by only deleting its state. Before: ``` //src/test/java/com/google/devtools/build/lib/remote:BuildWithoutTheBytesIntegrationTest PASSED in 33.4s Stats over 5 runs: max = 33.4s, min = 28.8s, avg = 31.8s, dev = 1.7s ``` After: ``` //src/test/java/com/google/devtools/build/lib/remote:BuildWithoutTheBytesIntegrationTest PASSED in 11.5s Stats over 5 runs: max = 11.5s, min = 9.0s, avg = 10.0s, dev = 0.8s ``` Requires fixing an `InputStream` leak in `DiskCacheClient`. Suggested in bazelbuild#25412 (comment) Closes bazelbuild#25432. PiperOrigin-RevId: 734107531 Change-Id: Icf8f593f8c368c5d9daa36002a6fb1aa9b789dca
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
This makes it easier to use in tests and also avoids restarting the worker for each test by only deleting its state. Before: ``` //src/test/java/com/google/devtools/build/lib/remote:BuildWithoutTheBytesIntegrationTest PASSED in 33.4s Stats over 5 runs: max = 33.4s, min = 28.8s, avg = 31.8s, dev = 1.7s ``` After: ``` //src/test/java/com/google/devtools/build/lib/remote:BuildWithoutTheBytesIntegrationTest PASSED in 11.5s Stats over 5 runs: max = 11.5s, min = 9.0s, avg = 10.0s, dev = 0.8s ``` Requires fixing an `InputStream` leak in `DiskCacheClient`. Suggested in #25412 (comment) Closes #25432. PiperOrigin-RevId: 734107531 Change-Id: Icf8f593f8c368c5d9daa36002a6fb1aa9b789dca Commit 7bc4469 Co-authored-by: Fabian Meumertzheim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to use in tests and also avoids restarting the worker for each test by only deleting its state.
Before:
After:
Requires fixing an
InputStreamleak inDiskCacheClient.Suggested in #25412 (comment)