Skip strategies incompatible with path mapping during resolution#25430
Closed
fmeum wants to merge 14 commits intobazelbuild:masterfrom
Closed
Skip strategies incompatible with path mapping during resolution#25430fmeum wants to merge 14 commits intobazelbuild:masterfrom
fmeum wants to merge 14 commits intobazelbuild:masterfrom
Conversation
fmeum
force-pushed
the
can-exec-sandboxed
branch
from
f89ad1d to
3003045
Compare
github-actions
bot
added
team-Performance
Collaborator
Author
|
@bazel-io fork 8.2.0 |
hoffbrinkle
reviewed
Mar 8, 2025
src/main/java/com/google/devtools/build/lib/actions/Spawns.java
Outdated
Show resolved
Hide resolved
tjgq
reviewed
Mar 11, 2025
src/main/java/com/google/devtools/build/lib/exec/SpawnStrategyResolver.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
can-exec-sandboxed
branch
from
e5e71f5 to
e91d2b3
Compare
fmeum
force-pushed
the
can-exec-sandboxed
branch
from
e91d2b3 to
60fa563
Compare
Collaborator
Author
|
I fixed the CI failures. |
tjgq
requested changes
Mar 24, 2025
src/main/java/com/google/devtools/build/lib/worker/WorkerParser.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java
Outdated
Show resolved
Hide resolved
Spawn strategies that aren't sandboxed are now skipped while resolving a strategy for a path mapped spawn, which allows non-sandboxed strategies to be listed first and also results in a better error message if no compatible strategy is available (instead of an obscure exec failure).
Collaborator
Author
|
@bazel-io fork 8.4.0 |
tjgq
approved these changes
Jul 16, 2025
tjgq
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jul 17, 2025
Spawn strategies that aren't sandboxed are now skipped while resolving a strategy for a path mapped spawn, which allows non-sandboxed strategies to be listed first and also results in a better error message if no compatible strategy is available (instead of an obscure exec failure). Worker execution is special in that it can always sandbox if needed, but may not do so based on options. For this purpose, path mapped spawns are now treated just like dynamically executed spawns by forcing sandboxing. In the future, the same mechanism can potentially be used to run spawns for rewound actions in Bazel, which must not delete or override their previous outputs. Work towards bazelbuild#22658 (comment) Fixes bazel-contrib/rules_go#4366 Closes bazelbuild#25430. PiperOrigin-RevId: 784040555 Change-Id: I26e110801ce84c41aef5f3e03e34879c595ebedf
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
…ion (#26563) Spawn strategies that aren't sandboxed are now skipped while resolving a strategy for a path mapped spawn, which allows non-sandboxed strategies to be listed first and also results in a better error message if no compatible strategy is available (instead of an obscure exec failure). Worker execution is special in that it can always sandbox if needed, but may not do so based on options. For this purpose, path mapped spawns are now treated just like dynamically executed spawns by forcing sandboxing. In the future, the same mechanism can potentially be used to run spawns for rewound actions in Bazel, which must not delete or override their previous outputs. Work towards #22658 (comment) Fixes bazel-contrib/rules_go#4366 Closes #25430. PiperOrigin-RevId: 784040555 Change-Id: I26e110801ce84c41aef5f3e03e34879c595ebedf Commit a42c981 Co-authored-by: Fabian Meumertzheim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawn strategies that aren't sandboxed are now skipped while resolving a strategy for a path mapped spawn, which allows non-sandboxed strategies to be listed first and also results in a better error message if no compatible strategy is available (instead of an obscure exec failure).
Worker execution is special in that it can always sandbox if needed, but may not do so based on options. For this purpose, path mapped spawns are now treated just like dynamically executed spawns by forcing sandboxing.
In the future, the same mechanism can potentially be used to run spawns for rewound actions in Bazel, which must not delete or override their previous outputs.
Work towards #22658 (comment)
Fixes bazel-contrib/rules_go#4366