Skip to content

Add bazel mod tidy dry run#25246

Closed
numine777 wants to merge 5 commits intobazelbuild:release-7.5.0from
numine777:add-mody-tidy-nowrite
Closed

Add bazel mod tidy dry run#25246
numine777 wants to merge 5 commits intobazelbuild:release-7.5.0from
numine777:add-mody-tidy-nowrite

Conversation

@numine777
Copy link

This PR addresses issue 24263

We needed this change for our CI as we are migrating to bzlmod. I have patched our current internal version (7.3.1) with this change and plan to update the patch when we move to Bazel 8 (at which time I can submit a PR to future Bazel 8 releases as well).

Please let me know if this PR needs any additional updates to documentation or testing before it is viable. I merely saw that the issue was tagged as a good first issue and thought I would jump in!

@numine777 numine777 requested a review from a team as a code owner February 11, 2025 15:34
@google-cla
Copy link

google-cla bot commented Feb 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

* Allow bazel mod tidy to take a `write` option that determines whether
fixes are made to files in place
  -> Defaults to true
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Feb 11, 2025
@numine777 numine777 force-pushed the add-mody-tidy-nowrite branch from 1f08d9e to de8880d Compare February 11, 2025 15:38
JIRA Tracking ID:

Description:

Test Notes:

Release Notes:
JIRA Tracking ID:

Description:

Test Notes:

Release Notes:
@meteorcloudy
Copy link
Member

Please send a PR to the main branch

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 19, 2025
@iancha1992 iancha1992 added the potential 7.x cherry-picks Potential cherry-picks for the next 7.x release. We'll consider a new 7.x release if enough issues label Feb 26, 2025
@iancha1992
Copy link
Member

iancha1992 commented Mar 4, 2025

@numine777 If this is merged to the master branch, then please feel free to cherry-pick the commit to our new release-7.6.0 branch. We are looking to release 7.6.0. Thanks!

@iancha1992
Copy link
Member

@fmeum Looks like we're out of time and we're about to get the rc1 out soon for 7.6.0. Are you okay with not including this for our 7.6.0 release?

@numine777
Copy link
Author

I apologize for missing the deadline. What would you like me to target for my next inclusion for the bazel 7 branch?

@iancha1992
Copy link
Member

@numine777 Please create a PR to the master branch. And if we have another 7.x release, we'll cherry-pick it. Thanks!

@iancha1992 iancha1992 removed the potential 7.x cherry-picks Potential cherry-picks for the next 7.x release. We'll consider a new 7.x release if enough issues label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants