Revert "Revert https://github.com/bazelbuild/bazel/commit/7f6e6496726aad4038368979c772e944bc323b7f"#25154
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
This reverts commit d165140. Fixes: * Allow toolchain variables to be `None` and skip them in that case, matching the previous behavior. * Use the effective output paths mode for fingerprinting to preserve action cache entries for non-path mapped actions even when path mapping is generally enabled.
fmeum
requested review from
a team,
comius,
lberki,
pzembrod and
trybka
as code owners
fmeum
changed the title
github-actions
bot
added
team-Performance
fmeum
requested review from
hvadehra
and removed request for
gregestren,
lberki,
pzembrod and
trybka
Collaborator
Author
|
@bazel-io fork 8.1.0 |
Contributor
|
I'm doing a manual import of this PR. |
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 31, 2025
…ppArchive` This mostly requires wiring up the existing machinery for structured variables and (most) link build variables. Utility methods on `PathMappers` are moved to `PathMapper` so that they can be dependend on by `AbstractCommandLine` without creating a cycle. NEW: - Allow toolchain variables to be None and skip them in that case, matching the previous behavior. - Use the effective output paths mode for fingerprinting to preserve action cache entries for non-path mapped actions even when path mapping is generally enabled. Closes bazelbuild#25154. PiperOrigin-RevId: 721850758 Change-Id: I34a66006ba4c8fd73d62ce8cea249577f62a1b02
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
…rchive` (#25162) This mostly requires wiring up the existing machinery for structured variables and (most) link build variables. Utility methods on `PathMappers` are moved to `PathMapper` so that they can be dependend on by `AbstractCommandLine` without creating a cycle. NEW: - Allow toolchain variables to be None and skip them in that case, matching the previous behavior. - Use the effective output paths mode for fingerprinting to preserve action cache entries for non-path mapped actions even when path mapping is generally enabled. Closes #25154. PiperOrigin-RevId: 721850758 Change-Id: I34a66006ba4c8fd73d62ce8cea249577f62a1b02 Commit 08f0709 --------- Co-authored-by: Fabian Meumertzheim <[email protected]> Co-authored-by: iancha1992 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d165140.
Fixes:
Noneand skip them in that case, matching the previous behavior.