[7.5.0] Backport support for all attribute types in Starlark documentation extraction #25093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetromino
added
the
team-Starlark-Integration
github-actions
bot
added
the
awaiting-review
…ation extraction Previously, we only supported attribute types which could be defined for Starlark rules, with the result that a cherry-pick in the 7.x branch exposing a formerly native-only attribute type to Starlark broke Stardoc: bazelbuild/stardoc#277 Instead of picking and choosing, let's support all attribute types, same as we already do in Bazel 8 and newer. Cherry-pick of a subset of changes in commit bazelbuild@1ce4ab1 PiperOrigin-RevId: 675169119 Change-Id: I6541a5eb99d6257339032850d360d2da4bd5aeb4
tetromino
force-pushed
the
release-7.5.0-stardoc
branch
from
0d68055 to
4cf3a30
Compare
Wyverald
approved these changes
Jan 27, 2025
Merged
via the queue into
bazelbuild:release-7.5.0
with commit Jan 27, 2025
c6aaa3e
50 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only supported attribute types which could be defined for Starlark rules, with the result that a cherry-pick in the 7.x branch exposing a formerly native-only attribute type to Starlark broke Stardoc: bazelbuild/stardoc#277
Instead of picking and choosing, let's support all attribute types, same as we already do in Bazel 8 and newer.
Cherry-pick of a subset of changes in commit
1ce4ab1
PiperOrigin-RevId: 675169119
Change-Id: I6541a5eb99d6257339032850d360d2da4bd5aeb4