Remove no-op --block_for_lock command option
#24953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.
Collaborator
Author
|
@bazel-io fork 7.5.0 |
github-actions
bot
added
the
awaiting-review
Collaborator
Author
|
@bazel-io fork 8.1.0 |
This was referenced Jan 17, 2025
meisterT
approved these changes
Jan 20, 2025
meisterT
added
awaiting-PR-merge
sgowroji
added
the
team-OSS
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 21, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing. Closes bazelbuild#24953. PiperOrigin-RevId: 717853503 Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 21, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing. Closes bazelbuild#24953. PiperOrigin-RevId: 717853503 Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing. Closes #24953. PiperOrigin-RevId: 717853503 Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef Commit 79508be Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing. Closes #24953. PiperOrigin-RevId: 717853503 Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef Commit 79508be Co-authored-by: Fabian Meumertzheim <[email protected]>
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 29, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing. Closes bazelbuild#24953. PiperOrigin-RevId: 717853503 Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.