Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 28, 2024

This makes it easier for users to discover that a module hasn't been found because its absence was recorded in the lockfile during a previous build.

Fixes #24803

This makes it easier for users to discover that a module hasn't been found because its absence was recorded in the lockfile during a previous build.
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Dec 28, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 28, 2024

@bazel-io fork 7.5.0

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 28, 2024

@bazel-io fork 8.1.0

@fmeum fmeum requested a review from meteorcloudy January 2, 2025 19:28
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 3, 2025
@copybara-service copybara-service bot closed this in 6061e5e Jan 8, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 8, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 8, 2025
This makes it easier for users to discover that a module hasn't been found because its absence was recorded in the lockfile during a previous build.

Fixes bazelbuild#24803

Closes bazelbuild#24804.

PiperOrigin-RevId: 713142592
Change-Id: Id541f5710481bd947c09d8dba315d683a1666b1c
@fmeum fmeum deleted the 24803-not-found branch January 8, 2025 09:14
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 9, 2025
This makes it easier for users to discover that a module hasn't been found because its absence was recorded in the lockfile during a previous build.

Fixes bazelbuild#24803

Closes bazelbuild#24804.

PiperOrigin-RevId: 713142592
Change-Id: Id541f5710481bd947c09d8dba315d683a1666b1c
(cherry picked from commit 6061e5e)
meteorcloudy pushed a commit that referenced this pull request Jan 13, 2025
This makes it easier for users to discover that a module hasn't been
found because its absence was recorded in the lockfile during a previous
build.

Fixes #24803

Closes #24804.

PiperOrigin-RevId: 713142592
Change-Id: Id541f5710481bd947c09d8dba315d683a1666b1c 
(cherry picked from commit 6061e5e)

Fixes #24805
github-merge-queue bot pushed a commit that referenced this pull request Jan 20, 2025
This makes it easier for users to discover that a module hasn't been
found because its absence was recorded in the lockfile during a previous
build.

Fixes #24803

Closes #24804.

PiperOrigin-RevId: 713142592
Change-Id: Id541f5710481bd947c09d8dba315d683a1666b1c

Commit
6061e5e

Co-authored-by: Fabian Meumertzheim <[email protected]>
Co-authored-by: Ian (Hee) Cha <[email protected]>
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 29, 2025
This makes it easier for users to discover that a module hasn't been found because its absence was recorded in the lockfile during a previous build.

Fixes bazelbuild#24803

Closes bazelbuild#24804.

PiperOrigin-RevId: 713142592
Change-Id: Id541f5710481bd947c09d8dba315d683a1666b1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module mapping error message needs to be more actionable.

2 participants