Remove allocation instrumenter jar and update version in docs #24783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
meisterT
and removed request for
fweikert and
gregestren
github-actions
bot
added
team-Performance
fmeum
changed the title
Collaborator
Author
|
@bazel-io fork 7.5.0 |
Collaborator
Author
|
@bazel-io fork 8.0.1 |
This was referenced Dec 23, 2024
meisterT
approved these changes
Jan 7, 2025
Wyverald
added
awaiting-PR-merge
Member
|
@fmeum Can you rebase and resolve the conflict? /cc @satyanandak |
The jar needs to supplied separately so that it can be passed to the `-javaagent` JVM arg and thus doesn't need to be part of the server jar. Also update the recommended version for compatibility with Java 21.
fmeum
force-pushed
the
24782-memory-tracker
branch
from
245cb0c to
7bef0d0
Compare
Collaborator
Author
|
@meteorcloudy Done |
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 13, 2025
The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes bazelbuild#24782 Closes bazelbuild#24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22 (cherry picked from commit b59fbee)
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 13, 2025
The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes bazelbuild#24782 Closes bazelbuild#24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22 (cherry picked from commit b59fbee)
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 13, 2025
The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes bazelbuild#24782 Closes bazelbuild#24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22 (cherry picked from commit b59fbee)
meteorcloudy
pushed a commit
that referenced
this pull request
Jan 13, 2025
…#24912) The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes #24782 Closes #24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22 (cherry picked from commit b59fbee) Fixes #24788
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 14, 2025
The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes bazelbuild#24782 Closes bazelbuild#24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 18, 2025
The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes bazelbuild#24782 Closes bazelbuild#24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22 (cherry picked from commit b59fbee)
iancha1992
pushed a commit
that referenced
this pull request
Jan 20, 2025
…#24913) The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes #24782 Closes #24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22 (cherry picked from commit b59fbee) Fixes #24789
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 29, 2025
The jar can be supplied separately as it needs to be passed to the `-javaagent` JVM arg anyway. Also update the recommended version for compatibility with Java 21. Fixes bazelbuild#24782 Closes bazelbuild#24783. PiperOrigin-RevId: 714057306 Change-Id: Ic8d47562f15344ed16d0af5d3242937d2ee53b22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jar can be supplied separately as it needs to be passed to the
-javaagentJVM arg anyway.Also update the recommended version for compatibility with Java 21.
Fixes #24782