Include apparent names of deps in bazel mod JSON output
#23787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@bazel-io fork 7.4.0 |
fmeum
force-pushed
the
22691-bazel-mod-apparent-name
branch
from
e0a4ce7 to
7bb1ad2
Compare
github-actions
bot
added
team-ExternalDeps
Collaborator
Author
|
@meteorcloudy @Wyverald I'm planning to pair this with another PR that allows |
fmeum
force-pushed
the
22691-bazel-mod-apparent-name
branch
from
7bb1ad2 to
9f00f77
Compare
Wyverald
approved these changes
Nov 5, 2024
Wyverald
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 8.0.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 6, 2024
This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module. Also always emit `name` and `version` so that consumers don't have to know how to parse module keys. Work towards bazelbuild#22691 Closes bazelbuild#23787. PiperOrigin-RevId: 693453084 Change-Id: Ie3fd5e89301d8e83d0eaa686188634923853f01a
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
…4234) This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module. Also always emit `name` and `version` so that consumers don't have to know how to parse module keys. Work towards #22691 Closes #23787. PiperOrigin-RevId: 693453084 Change-Id: Ie3fd5e89301d8e83d0eaa686188634923853f01a Commit 1003d2c Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
…4234) This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module. Also always emit `name` and `version` so that consumers don't have to know how to parse module keys. Work towards #22691 Closes #23787. PiperOrigin-RevId: 693453084 Change-Id: Ie3fd5e89301d8e83d0eaa686188634923853f01a Commit 1003d2c Co-authored-by: Fabian Meumertzheim <[email protected]>
Collaborator
Author
|
@bazel-io fork 7.5.0 |
ramil-bitrise
pushed a commit
to bitrise-io/bazel
that referenced
this pull request
Dec 18, 2024
This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module. Also always emit `name` and `version` so that consumers don't have to know how to parse module keys. Work towards bazelbuild#22691 Closes bazelbuild#23787. PiperOrigin-RevId: 693453084 Change-Id: Ie3fd5e89301d8e83d0eaa686188634923853f01a
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 7, 2025
This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module. Also always emit `name` and `version` so that consumers don't have to know how to parse module keys. Work towards bazelbuild#22691 Closes bazelbuild#23787. PiperOrigin-RevId: 693453084 Change-Id: Ie3fd5e89301d8e83d0eaa686188634923853f01a (cherry picked from commit 1003d2c) Fixes bazelbuild#24678
meteorcloudy
pushed a commit
that referenced
this pull request
Jan 9, 2025
…4847) This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module. Also always emit `name` and `version` so that consumers don't have to know how to parse module keys. Work towards #22691 Closes #23787. PiperOrigin-RevId: 693453084 Change-Id: Ie3fd5e89301d8e83d0eaa686188634923853f01a (cherry picked from commit 1003d2c) Fixes #24678
hb-man
pushed a commit
to JetBrains/hirschgarten
that referenced
this pull request
Jan 9, 2026
... instead of using the repository mapping to get them from the keys. The aparent name is set[1] in all versions since bazel 7.4 and hence, in particular, in all supported versions of bazel. Also use the name set by bazel instead of reverse engineering it from the key. By using the apparent name set by bazel, we also get the most useful apparent name, i.e., the one used in the repository closest to the main one. In particular, we avoid having to invert a repository mapping which is not a meaningful operation, given that the map depends on the repository the resolution happens in. [1] bazelbuild/bazel#23787 GitOrigin-RevId: c3932a800e45eb4c53e6cf32e1af2d2457ba4d7b
hb-man
pushed a commit
to JetBrains/hirschgarten
that referenced
this pull request
Jan 12, 2026
... instead of using the repository mapping to get them from the keys. The aparent name is set[1] in all versions since bazel 7.4 and hence, in particular, in all supported versions of bazel. Also use the name set by bazel instead of reverse engineering it from the key. By using the apparent name set by bazel, we also get the most useful apparent name, i.e., the one used in the repository closest to the main one. In particular, we avoid having to invert a repository mapping which is not a meaningful operation, given that the map depends on the repository the resolution happens in. [1] bazelbuild/bazel#23787 GitOrigin-RevId: 0b66b94f4a2d7d949ac7d927bdbe0b267c449cf9
hb-man
pushed a commit
to JetBrains/hirschgarten
that referenced
this pull request
Jan 12, 2026
... instead of using the repository mapping to get them from the keys. The aparent name is set[1] in all versions since bazel 7.4 and hence, in particular, in all supported versions of bazel. Also use the name set by bazel instead of reverse engineering it from the key. By using the apparent name set by bazel, we also get the most useful apparent name, i.e., the one used in the repository closest to the main one. In particular, we avoid having to invert a repository mapping which is not a meaningful operation, given that the map depends on the repository the resolution happens in. [1] bazelbuild/bazel#23787 GitOrigin-RevId: 0b66b94f4a2d7d949ac7d927bdbe0b267c449cf9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows IDEs to query for the direct dependencies of the root module as well as how they can refer to them from the point of view of the root module.
Also always emit
nameandversionso that consumers don't have to know how to parse module keys.Work towards #22691