Skip to content

Add support for in-memory outputs to output reuse#23422

Closed
fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum:reuse-inline-outputs
Closed

Add support for in-memory outputs to output reuse#23422
fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum:reuse-inline-outputs

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented Aug 26, 2024

No description provided.

@fmeum fmeum requested a review from a team as a code owner August 26, 2024 14:04
@github-actions github-actions bot added team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Aug 26, 2024
@fmeum fmeum requested review from tjgq and removed request for a team August 26, 2024 14:05
@fmeum fmeum force-pushed the reuse-inline-outputs branch from d786742 to 1e66d3a Compare August 28, 2024 14:21
@fmeum fmeum requested review from a team and lberki as code owners August 28, 2024 14:21
@fmeum fmeum requested review from aranguyen and tjgq and removed request for a team August 28, 2024 14:21
@tjgq
Copy link
Copy Markdown
Contributor

tjgq commented Aug 28, 2024

Importing this one myself since internal changes are required.

@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented Aug 28, 2024

@bazel-io fork 7.4.0

@fmeum fmeum force-pushed the reuse-inline-outputs branch from 37b9ad8 to 3dfd5e5 Compare August 29, 2024 09:49
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented Aug 29, 2024

I resolved the merge conflict.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Aug 30, 2024
@fmeum fmeum deleted the reuse-inline-outputs branch August 30, 2024 12:55
fmeum added a commit to fmeum/bazel that referenced this pull request Sep 19, 2024
Closes bazelbuild#23422.

PiperOrigin-RevId: 669296792
Change-Id: If3a2519cbf57cc82f1f733900b93705065b37e63
@fmeum fmeum mentioned this pull request Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
Cherry-picks the following changes to implement output reuse:
* Deduplicate locally executed path mapped spawns (#22556)
* Fix local execution deduplication to work with optional outputs
(#23296)
* Force synchronous upload and reuse of possibly modified spawn outputs
(#23382)
* Add support for in-memory outputs to output reuse (#23422)

Fixes #23377
Fixes #23444
Fixes #23457
@iancha1992
Copy link
Copy Markdown
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants