WIP: disable WORKSPACE in shell integration tests#23087
Closed
meteorcloudy wants to merge 107 commits intobazelbuild:masterfrom
Closed
WIP: disable WORKSPACE in shell integration tests#23087meteorcloudy wants to merge 107 commits intobazelbuild:masterfrom
meteorcloudy wants to merge 107 commits intobazelbuild:masterfrom
Conversation
github-actions
bot
added
team-Android
13 tasks
Contributor
|
All of the native Android rule tests require WORKSPACE to exist, so I think CI won't pass until we delete those tests and eventually the rules. |
Member
Author
Do you still want to keep the android tests in Bazel repo? (We disabled them on macOS already) If so, we can still set |
Contributor
|
I don't think we've migrated all of these tests to rules_android yet, so we can't outright delete them for now. I'd be OK with disabling them for Linux and Windows to unblock this work. |
Member
Author
|
Got it, then I'll just enable WORKSPACE for those tests to keep them running. |
meteorcloudy
force-pushed
the
disable_workspace_sh
branch
4 times, most recently
from
f1e76db to
533d3a7
Compare
meteorcloudy
force-pushed
the
disable_workspace_sh
branch
from
c59347b to
722a3f9
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
- Added functions for setting up common dependencies in MODULE.bazel - Use a shorter bazel_root on Windows - Added setup_module_dot_bazel to replace write_default_lockfile eventually - Removed TEST_REPOSITORY_HOME support A part of #23087 Working towards: #23023 PiperOrigin-RevId: 660748611 Change-Id: I55193953b429c18414ec092f567c98af36d7c34a
Member
Author
|
This PR has been broken down and merged. |
github-actions
bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #23023
This PR is huge, I'm going to try to break it down: