[7.2.0] Make Bazel changes for oneversion support
#22635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial cherry-pick of 417c6b8 which excludes the changes to `oneversion` itself, which is built and released for Bazel 7 as part of java_tools: * Avoid passing --whitelist to one_version if no allowlist is configured in the toolchain as it isn't supported by the Bazel version of oneversion yet. * Document the one_version flags. * Clean up tests not updated after recent rules_java releases.
github-actions
bot
added
awaiting-review
keertk
changed the title
oneversion supportoneversion support
Member
|
@fmeum, how urgent is this change? And how would you characterize the risk for breakage if we include it? I'm asking because even though we're doing an rc3, I'd very much like to avoid any further delays on the release. Ideally we shouldn't be cherry-picking anything that's not an rc1/rc2 regression at this point. |
Collaborator
Author
|
I fully understand your concerns, happy to provide the context for you to make a call:
|
Member
|
Well, turned out we need 193b114 to make sure Bazel still builds in our trusted environment where there is an older macOS version. |
Member
|
Oh, just realized this is a partial cherry-pick, which doesn't touch abseil-cpp version, then we don't need the fix on the main branch. |
Member
Member
|
Sounds good! @cushon could you approve the PR please? |
Wyverald
approved these changes
Jun 5, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial cherry-pick of 417c6b8 which excludes the changes to
oneversionitself, which is built and released for Bazel 7 as part of java_tools:Fixes #22576