[7.2.0] Keep /external:I... on a single param file line
#22628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC fails if `/external:I <some_path>` is broken into two lines in `.param` files. This is avoided by using the alternative `/external:I<some_path>` form. Fixes bazelbuild#22614 Closes bazelbuild#22616. PiperOrigin-RevId: 640055579 Change-Id: I5fda2714dc479fd76f22e2f8562dddbdfcdb9a18
bazel-io
added
team-Rules-CPP
meteorcloudy
approved these changes
Jun 4, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC fails if
/external:I <some_path>is broken into two lines in.paramfiles. This is avoided by using the alternative/external:I<some_path>form.Fixes #22614
Closes #22616.
PiperOrigin-RevId: 640055579
Change-Id: I5fda2714dc479fd76f22e2f8562dddbdfcdb9a18
Commit 759fe7d