Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented May 27, 2024

…iables

This change prepares for C++ path mapping, which also needs to map include directories of generated headers. It may, as a side effect, reduce memory usage slightly by possibly reusing nested set instances retained elsewhere.

Work towards #6526

Closes #22463.

PiperOrigin-RevId: 636886343
Change-Id: Ic93d6439a51f37f44bb2ac67d0813c48c0c4a8bd

Fixes #22533

…iables

This change prepares for C++ path mapping, which also needs to map include directories of generated headers. It may, as a side effect, reduce memory usage slightly by possibly reusing nested set instances retained elsewhere.

Work towards bazelbuild#6526

Closes bazelbuild#22463.

PiperOrigin-RevId: 636886343
Change-Id: Ic93d6439a51f37f44bb2ac67d0813c48c0c4a8bd
@fmeum fmeum requested a review from a team as a code owner May 27, 2024 20:19
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules labels May 27, 2024
@fmeum fmeum changed the title Add NestedSet<PathFragment>- and Artifact-typed compile build var… [7.2.0] Add NestedSet<PathFragment>- and Artifact-typed compile build var… May 28, 2024
@keertk keertk requested review from Wyverald and comius May 28, 2024 15:00
@keertk keertk enabled auto-merge May 28, 2024 15:00
@keertk
Copy link
Member

keertk commented May 28, 2024

@Wyverald could you approve this one too?

@keertk keertk added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@keertk keertk added this pull request to the merge queue May 28, 2024
Merged via the queue into bazelbuild:release-7.2.0 with commit 84f4b55 May 28, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 28, 2024
@fmeum fmeum deleted the 22533 branch May 28, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-CPP Issues for C++ rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants