Fix getting authentication for URLs in http repo rules #22517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
meteorcloudy
requested review from
Wyverald and
fmeum
and removed request for
Wyverald
Member
Author
|
@bazel-io fork 7.2.0 |
fmeum
reviewed
May 23, 2024
| for p in pending: | ||
| p.wait() | ||
|
|
||
| def patch(ctx, patches = None, patch_cmds = None, patch_cmds_win = None, patch_tool = None, patch_args = None, auth = None): |
Member
Author
There was a problem hiding this comment.
Nice catch, I added it back as a way to override the auth by user.
iancha1992
added
the
team-ExternalDeps
meteorcloudy
commented
May 24, 2024
meteorcloudy
force-pushed
the
fix_download_url
branch
from
7c3376f to
19cfdf8
Compare
meteorcloudy
changed the title
meteorcloudy
force-pushed
the
fix_download_url
branch
from
19cfdf8 to
404a501
Compare
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 29, 2024
- Fixed the leak of `remote_patches` URLs for downloaded the source archive. - Compute auth for required URLs only Fixes bazelbuild#22201 Closes bazelbuild#22517. PiperOrigin-RevId: 638300996 Change-Id: Ib76e3284f209d2314844cfd662ac8eadba785fae
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 29, 2024
- Fixed the leak of `remote_patches` URLs for downloaded the source archive. - Compute auth for required URLs only Fixes #22201 Closes #22517. PiperOrigin-RevId: 638300996 Change-Id: Ib76e3284f209d2314844cfd662ac8eadba785fae Commit 5986420 Co-authored-by: Yun Peng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote_patchesURLs for downloaded the source archive.Fixes #22201