Validate label attributes of repositories created by module extensions #22495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
Wyverald
reviewed
May 22, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java
Outdated
Show resolved
Hide resolved
Wyverald
reviewed
May 22, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
Wyverald
reviewed
May 22, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
Catches a common gotcha of referencing a repo created by an extension elsewhere in an extension without a `use_repo` and provides actionable advice to user. This also prevents lockfile corruption caused by non-visible labels.
fmeum
force-pushed
the
21845-invalid-ext-labels
branch
from
8c82249 to
45dc66c
Compare
fmeum
force-pushed
the
21845-invalid-ext-labels
branch
from
45dc66c to
a1158b3
Compare
fmeum
force-pushed
the
21845-invalid-ext-labels
branch
from
a1158b3 to
39a902a
Compare
Wyverald
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 7.2.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 24, 2024
Catches a common gotcha of referencing a repo created by an extension elsewhere in an extension without a `use_repo` and provides actionable advice to user. This prevents lockfile corruption caused by non-visible labels. The same validation is applied to labels in tag attributes. Fixes bazelbuild#21845 Closes bazelbuild#22495. PiperOrigin-RevId: 636939357 Change-Id: Ib779207502f7767e4e8d3abc55ba7470f75821b9
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 24, 2024
…xtensions (#22537) Catches a common gotcha of referencing a repo created by an extension elsewhere in an extension without a `use_repo` and provides actionable advice to user. This prevents lockfile corruption caused by non-visible labels. The same validation is applied to labels in tag attributes. Fixes #21845 Closes #22495. PiperOrigin-RevId: 636939357 Change-Id: Ib779207502f7767e4e8d3abc55ba7470f75821b9 Commit aa436c3 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches a common gotcha of referencing a repo created by an extension elsewhere in an extension without a
use_repoand provides actionable advice to user. This prevents lockfile corruption caused by non-visible labels.The same validation is applied to labels in tag attributes.
Fixes #21845