Add --lockfile_mode=refresh
#22333
Closed
Add --lockfile_mode=refresh
#22333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Configurability
Collaborator
Author
|
I added the refresh logic. I didn't find a way to test it that would require making the timeout configurable, but I verified locally that it works with shorter durations. |
fmeum
force-pushed
the
20369-refresh
branch
2 times, most recently
from
9eb0064 to
d9bca3c
Compare
Wyverald
approved these changes
May 13, 2024
Member
Wyverald
left a comment
Wyverald
left a comment
There was a problem hiding this comment.
LGTM. just need some documentation updates etc
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/IndexRegistry.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/RegistryFunction.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/RegistryFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/BazelRepositoryModule.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/RegistryFunction.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@bazel-io fork 7.2.0 |
fmeum
removed
the
team-Configurability
Wyverald
approved these changes
May 14, 2024
Wyverald
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 14, 2024
RELNOTES: The new `refresh` value for `--lockfile_mode` behaves like the `update` mode, but additionally forces a refresh of mutable registry content (yanked versions and missing module versions) when switched to or from time to time while enabled. Closes bazelbuild#22333. PiperOrigin-RevId: 633737372 Change-Id: I2cae552f6adfcd07a5b3263b5e4997e21653f106
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
RELNOTES: The new `refresh` value for `--lockfile_mode` behaves like the `update` mode, but additionally forces a refresh of mutable registry content (yanked versions and missing module versions) when switched to or from time to time while enabled. Closes #22333. PiperOrigin-RevId: 633737372 Change-Id: I2cae552f6adfcd07a5b3263b5e4997e21653f106 Commit 88a230f --------- Co-authored-by: Fabian Meumertzheim <[email protected]> Co-authored-by: Xùdōng Yáng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELNOTES: The new
refreshvalue for--lockfile_modebehaves like theupdatemode, but additionally forces a refresh of mutable registry content (yanked versions and missing module versions) when switched to or from time to time while enabled.