Follow unconfigured aliases during options parsing
#22192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELNOTES: Starlark command-line flags can now be referred to through `alias` targets.
github-actions
bot
added
the
awaiting-review
Collaborator
Author
|
@gregestren I picked this up since it is relevant for a design I'm working on: I want to build a general-purpose features system for Bazel modules, similar to that of Cargo. Modules can declare configurable features and have appropriate custom Starlark flags generated for them in a repository rule, with a managed default value. But this is only likely to work well if a module can wrap these generated flags in Hope that motivates this, happy to explain more about the context if you have concerns. |
gregestren
reviewed
Apr 30, 2024
src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java
Outdated
Show resolved
Hide resolved
iancha1992
added
the
team-Configurability
gregestren
approved these changes
May 1, 2024
gregestren
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 7.2.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 1, 2024
Fixes bazelbuild#20582 RELNOTES: Starlark command-line flags can now be referred to through `alias` targets. Closes bazelbuild#22192. PiperOrigin-RevId: 629865954 Change-Id: I6215c8484ddc08e75507191bfa1eb5bc709c5fc6
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 2, 2024
Fixes #20582 RELNOTES: Starlark command-line flags can now be referred to through `alias` targets. Closes #22192. PiperOrigin-RevId: 629865954 Change-Id: I6215c8484ddc08e75507191bfa1eb5bc709c5fc6 Commit 43fdcd3 Co-authored-by: Fabian Meumertzheim <[email protected]>
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
Fixes bazelbuild#20582 RELNOTES: Starlark command-line flags can now be referred to through `alias` targets. Closes bazelbuild#22192. PiperOrigin-RevId: 629865954 Change-Id: I6215c8484ddc08e75507191bfa1eb5bc709c5fc6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20582
RELNOTES: Starlark command-line flags can now be referred to through
aliastargets.