Disable path mapping with local or no-{sandbox,remote} tags
#21921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Targets tagged with `local` or `no-sandbox` and `no-remote` can't successfully use path mapping and thus have it disabled implicitly.
fmeum
requested review from
aranguyen and
katre
and removed request for
a team and
katre
github-actions
bot
added
team-Configurability
gregestren
approved these changes
May 20, 2024
Contributor
gregestren
left a comment
gregestren
left a comment
There was a problem hiding this comment.
To refresh me, what's the current state with flags like --spawn_strategy or dynamic execution strategies?
gregestren
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 7.2.0 |
Collaborator
Author
They should be fully supported as long as the resulting strategy is sandboxed via symlinks or remote. |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 21, 2024
Targets tagged with `local` or `no-sandbox` and `no-remote` can't successfully use path mapping and thus have it disabled implicitly. Closes bazelbuild#21921. PiperOrigin-RevId: 635832339 Change-Id: Ib5cac0b202cbcd1704410f06fa3cda645581b849
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
…gs (#22467) Targets tagged with `local` or `no-sandbox` and `no-remote` can't successfully use path mapping and thus have it disabled implicitly. Closes #21921. PiperOrigin-RevId: 635832339 Change-Id: Ib5cac0b202cbcd1704410f06fa3cda645581b849 Commit 46dce83 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets tagged with
localorno-sandboxandno-remotecan't successfully use path mapping and thus have it disabled implicitly.