Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 5, 2024

This is in preparation for tracking the hashes of remote (non-file: URL) files in the lockfile. If the tests use local registries, they wouldn't be representative of the default situation.

Work towards #20369

This is in preparation for tracking the hashes of remote (non-`file:` URL) files in the lockfile.

Work towards bazelbuild#20369
self.main_registry = BazelRegistry(
os.path.join(self.registries_work_dir, 'main')
)
self.main_registry.start()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to adapt a with-able object for use in setUp/tearDown style function?

@fmeum fmeum marked this pull request as ready for review April 5, 2024 13:10
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Apr 5, 2024
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 5, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 5, 2024

@bazel-io fork 7.2.0

@copybara-service copybara-service bot closed this in 3f9d80c Apr 5, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Apr 5, 2024
This is in preparation for tracking the hashes of remote (non-`file:` URL) files in the lockfile. If the tests use local registries, they wouldn't be representative of the default situation.

Work towards bazelbuild#20369

Closes bazelbuild#21906.

PiperOrigin-RevId: 622290283
Change-Id: Ibe825d2bede84c1b0672dbb699aaf3ee5168a813
github-merge-queue bot pushed a commit that referenced this pull request Apr 5, 2024
This is in preparation for tracking the hashes of remote (non-`file:`
URL) files in the lockfile. If the tests use local registries, they
wouldn't be representative of the default situation.

Work towards #20369

Closes #21906.

PiperOrigin-RevId: 622290283
Change-Id: Ibe825d2bede84c1b0672dbb699aaf3ee5168a813

Commit
3f9d80c

Co-authored-by: Fabian Meumertzheim <[email protected]>
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 26, 2024
Kila2 pushed a commit to Kila2/bazel that referenced this pull request May 13, 2024
This is in preparation for tracking the hashes of remote (non-`file:` URL) files in the lockfile. If the tests use local registries, they wouldn't be representative of the default situation.

Work towards bazelbuild#20369

Closes bazelbuild#21906.

PiperOrigin-RevId: 622290283
Change-Id: Ibe825d2bede84c1b0672dbb699aaf3ee5168a813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants