Make cc_shared_library runnable standalone
#21882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
21833-python-test
branch
2 times, most recently
from
0e3059c to
e5c2128
Compare
fmeum
changed the title
cc_shared_library runnable standalone
Collaborator
Author
|
|
github-actions
bot
added
the
awaiting-review
pzembrod
approved these changes
May 15, 2024
src/main/starlark/tests/builtins_bzl/cc/cc_shared_library/test_cc_shared_library/python_test.py
Outdated
Show resolved
Hide resolved
pzembrod
added
awaiting-PR-merge
When loaded as a `data` dependency (e.g. for `dlopen`), the runfiles of a `cc_shared_library` now contain the `_solib` symlinks of precompiled dynamic library dependencies instead of the symlink targets.
Collaborator
Author
|
I rebased onto master, which will hopefully resolve the RBE failure. |
Collaborator
Author
|
@bazel-io fork 7.2.0 |
Contributor
|
I'll handle the import. |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 28, 2024
When loaded as a `data` dependency (e.g. for `dlopen`), the runfiles of a `cc_shared_library` now contain the `_solib` symlinks of precompiled dynamic library dependencies instead of the symlink targets. Work towards bazelbuild#21833 Closes bazelbuild#21882. PiperOrigin-RevId: 637807250 Change-Id: I7ea2858c8cc9b5072beecf01d9dd49f8385aaebd
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2024
When loaded as a `data` dependency (e.g. for `dlopen`), the runfiles of a `cc_shared_library` now contain the `_solib` symlinks of precompiled dynamic library dependencies instead of the symlink targets. Work towards #21833 Closes #21882. PiperOrigin-RevId: 637807250 Change-Id: I7ea2858c8cc9b5072beecf01d9dd49f8385aaebd Commit 75e5d2f Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loaded as a
datadependency (e.g. fordlopen), the runfiles of acc_shared_librarynow contain the_solibsymlinks of precompiled dynamic library dependencies instead of the symlink targets.Work towards #21833