Set public visibility for R8 desugar binary #21775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on @bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android. Part of bazelbuild/rules_android#122.
github-actions
bot
added
team-Android
ahumesky
approved these changes
Mar 22, 2024
github-actions
bot
removed
the
awaiting-review
Contributor
|
@bazel-io fork 7.1.2 |
Contributor
|
@bazel-io fork 7.2.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 29, 2024
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on @bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android. Part of bazelbuild/rules_android#122. Closes bazelbuild#21775. PiperOrigin-RevId: 618272641 Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1
Contributor
|
@bazel-io fork 7.2.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 29, 2024
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on @bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android. Part of bazelbuild/rules_android#122. Closes bazelbuild#21775. PiperOrigin-RevId: 618272641 Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1
This was referenced Apr 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on @bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android. Part of bazelbuild/rules_android#122. Closes #21775. PiperOrigin-RevId: 618272641 Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1 Commit 32fd6e9 Co-authored-by: Ted Xie <[email protected]>
Wyverald
added a commit
that referenced
this pull request
May 8, 2024
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on @bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android. Part of bazelbuild/rules_android#122. Closes #21775. PiperOrigin-RevId: 618272641 Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1 Commit 32fd6e9 Co-authored-by: Ted Xie <[email protected]> Co-authored-by: Xùdōng Yáng <[email protected]>
Contributor
Author
|
@bazel-io Fork 7.3.0 |
Contributor
Author
|
@bazel-io fork 7.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android.
Part of bazelbuild/rules_android#122.