Skip to content

Remove deprecated local resource flags #21684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlessandroPatti wants to merge 2 commits into from
Closed

Remove deprecated local resource flags #21684

AlessandroPatti wants to merge 2 commits into from

Conversation

@AlessandroPatti
Copy link
Contributor

@AlessandroPatti AlessandroPatti commented Mar 13, 2024

Follow up for #20398, kill deprecated flags.

@github-actions github-actions bot added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Mar 13, 2024
@AlessandroPatti AlessandroPatti force-pushed the apatti/19679/remove-flags branch from 59ad15d to 0eb0475 Compare March 13, 2024 22:08
@AlessandroPatti AlessandroPatti force-pushed the apatti/19679/remove-flags branch 3 times, most recently from 4429d09 to 7005dbb Compare March 14, 2024 09:09
@AlessandroPatti AlessandroPatti force-pushed the apatti/19679/remove-flags branch from 7005dbb to 102aa50 Compare May 1, 2024 20:41
@AlessandroPatti AlessandroPatti force-pushed the apatti/19679/remove-flags branch from 102aa50 to 9ce1a0a Compare August 7, 2024 14:33
@meisterT meisterT requested a review from zhengwei143 September 5, 2024 07:52
@zhengwei143
Copy link
Contributor

zhengwei143 commented Sep 17, 2024

I think there are still some usages of local_{ram,cpu}_resources internally that we need to migrate away from before we push through with this.

@meisterT
Copy link
Member

meisterT commented May 7, 2025

@bigelephant29 do you know the current state of the flag internally now?

@bigelephant29
Copy link
Contributor

bigelephant29 commented May 7, 2025

@bigelephant29 do you know the current state of the flag internally now?

It's on my radar but I'll need to find time revisiting those use cases. I'll sync up with you offline.

@AlessandroPatti AlessandroPatti force-pushed the apatti/19679/remove-flags branch from 9ce1a0a to 7c16a53 Compare September 17, 2025 20:27
@AlessandroPatti
Copy link
Contributor Author

AlessandroPatti commented Sep 17, 2025

@bigelephant29 worth pursing this or will it be take time to migrate internally?

@bigelephant29
Copy link
Contributor

bigelephant29 commented Sep 18, 2025

Thanks for the ping! It's in progress. More than 30 reviews ongoing internally, so it'll take a while. This is definitely still on our radar.

bigelephant29
bigelephant29 requested changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@bigelephant29 bigelephant29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. I'll discuss this CL with @zhengwei143.

zhengwei143
zhengwei143 reviewed Sep 24, 2025
View reviewed changes
@bigelephant29
Copy link
Contributor

bigelephant29 commented Oct 6, 2025

@AlessandroPatti This is just a friendly reminder :)

Hopefully we can ship this in Bazel 9.

bigelephant29
bigelephant29 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@bigelephant29 bigelephant29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

Please resolve the thread and let's initiate a submission.

@bigelephant29 bigelephant29 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 21, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigelephant29 bigelephant29 bigelephant29 approved these changes

@gregestren gregestren Awaiting requested review from gregestren gregestren is a code owner

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

@zhengwei143 zhengwei143 Awaiting requested review from zhengwei143

Assignees

No one assigned

Labels

team-Local-Exec Issues and PRs for the Execution (Local) team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlessandroPatti @zhengwei143 @meisterT @bigelephant29