Passthrough HTTP headers to remote downloader service#21490
Closed
sushain97 wants to merge 1 commit intobazelbuild:masterfrom
Closed
Passthrough HTTP headers to remote downloader service#21490sushain97 wants to merge 1 commit intobazelbuild:masterfrom
sushain97 wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
Bot
added
team-Remote-Exec
tjgq
approved these changes
Feb 26, 2024
tjgq
added
awaiting-PR-merge
Member
|
@bazel-io fork 7.1.0 |
github-actions
Bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 27, 2024
Related to bazelbuild#17829 and bazelbuild@2697e0c I don't love this design but according to the Remote Asset API spec, this is an intended use of qualifiers: https://docs.google.com/document/d/10ari9WtTTSv9bqB_UU-oe2gBtaAA7HyQgkpP-RFP80c/edit#heading=h.sixrlhdnkfoa. cc @Wyverald @jmillikin Closes bazelbuild#21490. PiperOrigin-RevId: 610688317 Change-Id: I272f63a6bc4ea432503003ee907ca012f6d641cf
Contributor
|
Sending the headers (especially |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Related to #17829 and 2697e0c I don't love this design but according to the Remote Asset API spec, this is an intended use of qualifiers: https://docs.google.com/document/d/10ari9WtTTSv9bqB_UU-oe2gBtaAA7HyQgkpP-RFP80c/edit#heading=h.sixrlhdnkfoa. cc @Wyverald @jmillikin Closes #21490. Commit 2195baa PiperOrigin-RevId: 610688317 Change-Id: I272f63a6bc4ea432503003ee907ca012f6d641cf Co-authored-by: Sushain Cherivirala <[email protected]>
Member
|
The changes in this PR have been included in Bazel 7.1.0 RC2. Please test out the release candidate and report any issues as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #17829 and 2697e0c
I don't love this design but according to the Remote Asset API spec, this is an intended use of qualifiers: https://docs.google.com/document/d/10ari9WtTTSv9bqB_UU-oe2gBtaAA7HyQgkpP-RFP80c/edit#heading=h.sixrlhdnkfoa.
cc @Wyverald @jmillikin