[test][windows] Export BAZEL_TEST=1 on windows#21444
[test][windows] Export BAZEL_TEST=1 on windows#21444cristiandonosoc wants to merge 6 commits intobazelbuild:masterfrom
Conversation
This was an oversight from when exporting BAZEL_TEST on Linux. fixes: bazelbuild#21420
|
I searched on https://github.com/bazelbuild/bazel/blob/4e43b4aaa3a0f85a6390326e245c675c091c965b/tools/test/windows/tw_test.cc to see how could I test this, but those are not blackbox run a subprocess and see what env variables were actually sent type of tests. Maybe that test is somewhere but I couldn't find it. If you could point me to it, I could perhaps add the test? |
An oversight, test pass now
|
Sorry for the messy CLs, but I don't want to install Java (and the other toolchains that might be required) just for this, so I'm abusing the CI a bit to run the tests for me. |
The other approach wouldn't have worked.
Now we correctly query for the env variable
|
Okay I stopped being lazy and figured how to run the tests locally ( Sorry for the spam. |
This was an oversight from when exporting BAZEL_TEST on Linux. fixes: bazelbuild#21420 Closes bazelbuild#21444. PiperOrigin-RevId: 610338496 Change-Id: Icbbdc42b6ea92a2de2b0c558aea47a24493c9d8a
This was an oversight from when exporting BAZEL_TEST on Linux. fixes: #21420 Closes #21444. Commit 0a9d612 PiperOrigin-RevId: 610338496 Change-Id: Icbbdc42b6ea92a2de2b0c558aea47a24493c9d8a Co-authored-by: Cristin Donoso <[email protected]>
This was an oversight from when exporting BAZEL_TEST on Linux.
fixes: #21420