Skip to content

Remove duplication in overriding java_tools and add a test for validating that overriding actually works#21364

Closed
hvadehra wants to merge 2 commits intomasterfrom
hvd-test-rules-java-repo-override
Closed

Remove duplication in overriding java_tools and add a test for validating that overriding actually works#21364
hvadehra wants to merge 2 commits intomasterfrom
hvd-test-rules-java-repo-override

Conversation

@hvadehra
Copy link
Copy Markdown
Member

Should help avoid issues like:

#21351

#20374

#20294 (comment)

@hvadehra hvadehra requested a review from fmeum February 15, 2024 09:51
@github-actions github-actions Bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 15, 2024
@hvadehra hvadehra force-pushed the hvd-test-rules-java-repo-override branch 2 times, most recently from 6370e6c to 20a6922 Compare February 15, 2024 09:53
@hvadehra hvadehra force-pushed the hvd-test-rules-java-repo-override branch from 20a6922 to 5805819 Compare February 15, 2024 10:06
Copy link
Copy Markdown
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread src/test/shell/bazel/BUILD Outdated
Co-authored-by: Fabian Meumertzheim <[email protected]>
@hvadehra hvadehra added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 15, 2024
@sgowroji sgowroji added the team-Rules-Java Issues for Java rules label Feb 16, 2024
@github-actions github-actions Bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 16, 2024
@hvadehra hvadehra deleted the hvd-test-rules-java-repo-override branch February 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-Java Issues for Java rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants