Skip to content

Temporarily hardcode rules_java repository name#21351

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:patch-9
Closed

Temporarily hardcode rules_java repository name#21351
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:patch-9

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented Feb 14, 2024

Fixes #21350

@fmeum fmeum requested a review from hvadehra February 14, 2024 17:16
@github-actions github-actions Bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 14, 2024
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented Feb 14, 2024

This is analogous to

bazel/BUILD

Line 192 in 1ef93be

content = ["rules_jvm_external~~maven~maven"],
.

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 14, 2024
@github-actions github-actions Bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 14, 2024
@fmeum fmeum deleted the patch-9 branch February 14, 2024 20:10
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented Feb 14, 2024

@bazel-io fork 7.1.0

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 14, 2024
Fixes bazelbuild#21350

Closes bazelbuild#21351.

PiperOrigin-RevId: 607063055
Change-Id: Ia80ba907d04718205658c3ad5d5fc801caf94535
github-merge-queue Bot pushed a commit that referenced this pull request Feb 14, 2024
Fixes #21350

Closes #21351.

Commit
eee416b

PiperOrigin-RevId: 607063055
Change-Id: Ia80ba907d04718205658c3ad5d5fc801caf94535

Co-authored-by: Fabian Meumertzheim <[email protected]>
copybara-service Bot pushed a commit that referenced this pull request Feb 16, 2024
…ting that overriding actually works

Should help avoid issues like:

#21351

#20374

#20294 (comment)

Closes #21364.

PiperOrigin-RevId: 607785065
Change-Id: Ib8c75d597911034091c3dafd638acfe72d2eb9c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label.repo_name no longer returns the canonical repo name

2 participants