Allow locally build actions with scrubber#21288
Closed
bozaro wants to merge 2 commits intobazelbuild:masterfrom
Closed
Allow locally build actions with scrubber#21288bozaro wants to merge 2 commits intobazelbuild:masterfrom
bozaro wants to merge 2 commits intobazelbuild:masterfrom
Conversation
github-actions
Bot
added
team-Remote-Exec
sgowroji
added
awaiting-user-response
tjgq
requested changes
Feb 15, 2024
Contributor
tjgq
left a comment
tjgq
left a comment
There was a problem hiding this comment.
Can you please add an integration test verifying that the fallback to local execution works? (Search for test_cache_key_scrubbing in //src/test/shell/bazel/remote/remote_execution_test.sh.)
tjgq
approved these changes
Feb 16, 2024
Contributor
tjgq
left a comment
tjgq
left a comment
There was a problem hiding this comment.
Looks good, thanks. We should also amend the description for the --experimental_remote_scrubbing_config flag, but I will do that myself when I import it.
Contributor
|
@bazel-io fork 7.1.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 16, 2024
…on is enabled. As discussed in bazelbuild#20070, it's sometimes useful to scrub actions in a build that is otherwise remote. Closes bazelbuild#21288. PiperOrigin-RevId: 607723207 Change-Id: I31403de74fb81d07aac765cca68b2991b0230496
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
… execution is enabled. (#21384) As discussed in #20070, it's sometimes useful to scrub actions in a build that is otherwise remote. Closes #21288. Commit 8e0343c PiperOrigin-RevId: 607723207 Change-Id: I31403de74fb81d07aac765cca68b2991b0230496 Co-authored-by: Artem V. Navrotskiy <[email protected]>
Member
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since cannot run remote cache key scrubbing action with remote execution, run this actions only locally. Actions without scrubber can still be executed remotely.
The part from #20070 that didn't cause much rejection.