Add target_kind to scrubber matching rules
#21151
Conversation
github-actions
bot
added
team-Remote-Exec
tjgq
left a comment
tjgq
left a comment
There was a problem hiding this comment.
Looks good to me, but please add tests in //src/test/java/com/google/devtools/build/lib/remote/ScrubberTest.java. You can use the test cases for label_regex (i.e., matchExactLabel, matchUnionLabel and matchWildcardLabel) as a starting point.
| // Whether to match actions built for a tool configuration. | ||
| // The default is to match only actions built for non-tool configurations. | ||
| bool match_tools = 3; | ||
| // A regex matching the action target kind. |
There was a problem hiding this comment.
"A regex matching the rule kind of the action owner."
tjgq
added
awaiting-user-response
bozaro
force-pushed
the
scrubbing-target-kind
branch
from
7ba6343 to
3428a6f
Compare
bozaro
force-pushed
the
scrubbing-target-kind
branch
from
3428a6f to
88fbad5
Compare
|
I don't believe the CI failures are related. Importing. |
|
@bazel-io fork 7.1.0 |
Add the target kind (e.g. java_library) to the scrubbing matcher configuration. This is useful because different kinds may use the same mnemonic, and specifying an explicit set of labels is labor-intensive and error-prone. Closes bazelbuild#21151. PiperOrigin-RevId: 605624773 Change-Id: Ib5748ca2dbb3fd6d30b27fc1b292d7cd826ced62
|
FYI - I renamed the |
…21276) Add the target kind (e.g. java_library) to the scrubbing matcher configuration. This is useful because different kinds may use the same mnemonic, and specifying an explicit set of labels is labor-intensive and error-prone. Closes #21151. Commit 4bcf855 PiperOrigin-RevId: 605624773 Change-Id: Ib5748ca2dbb3fd6d30b27fc1b292d7cd826ced62 Co-authored-by: Artem V. Navrotskiy <[email protected]>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
3 participants
Allow the use of the target kind (for example,
cc_library,go_binary,go_test...) in the scrubbing matcher configuration.This is useful, as different target kinds can have the same mnemonic.