Make repo marker files sensitive to repo mapping changes #21131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
meteorcloudy
added
awaiting-PR-merge
fmeum
approved these changes
Jan 30, 2024
...n/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryModule.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
Outdated
Show resolved
Hide resolved
lberki
reviewed
Jan 30, 2024
...java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryFunction.java
Show resolved
Hide resolved
...java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryFunction.java
Show resolved
Hide resolved
...java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryFunction.java
Show resolved
Hide resolved
….java Co-authored-by: Fabian Meumertzheim <[email protected]>
lberki
approved these changes
Jan 30, 2024
This reverts commit eae938e.
lberki
approved these changes
Jan 31, 2024
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 1, 2024
Similar to the fix for bazelbuild#20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes. Fixes bazelbuild#20722. Closes bazelbuild#21131. PiperOrigin-RevId: 603310262 Change-Id: I806f383e8579fed3533fac9b181efd8b75e76fcd
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
) Similar to the fix for #20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes. Fixes #20722. Closes #21131. Commit 9edaddd PiperOrigin-RevId: 603310262 Change-Id: I806f383e8579fed3533fac9b181efd8b75e76fcd Co-authored-by: Xdng Yng <[email protected]>
Wyverald
added a commit
that referenced
this pull request
Feb 16, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
See #21131 (comment) Closes #21390. PiperOrigin-RevId: 607821270 Change-Id: I031222ee80c4db4ca50372c549e2b522ac606cb7
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 17, 2024
See bazelbuild#21131 (comment) Closes bazelbuild#21390. PiperOrigin-RevId: 607821270 Change-Id: I031222ee80c4db4ca50372c549e2b522ac606cb7
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
See #21131 (comment) Closes #21390. Commit 38c1d5d PiperOrigin-RevId: 607821270 Change-Id: I031222ee80c4db4ca50372c549e2b522ac606cb7 Co-authored-by: Xdng Yng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the fix for #20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes.
Fixes #20722.